Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <f46af838-8b28-79e6-5298-4458b44664ca@mindspring.com>
In-Reply-To: <f46af838-8b28-79e6-5298-4458b44664ca@mindspring.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Mon, 28 Feb 2022 10:44:10 -0800
Message-ID: <CABBYNZLthsOUzh0ce9co1r9x02FRFPoBkTrpehUtUtMiwiyzGw@mail.gmail.com>
Subject: Re: Battery1 vs. GATT reporting
To:     Ed Beroset <beroset@mindspring.com>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Ed,

On Mon, Feb 28, 2022 at 9:45 AM Ed Beroset <beroset@mindspring.com> wrote:
>
> In
> https://git.kernel.org/pub/scm/bluetooth/bluez.git/commit/?id=713f6f09 a
> flag named "external" was added which, if I'm understanding correctly,
> is supposed to mark the Battery1 profile as safe to also share via GATT.
>   However, I was recently working on an application that relies on the
> GATT API for battery power and found that it only seemed to work as
> expected (reporting via both) if I set the flag to false rather than
> true as in the commit.  I looked through the code and it all looks
> correct, but my observation indicates that perhaps the sense of the flag
> is somehow inverted.
>
> Here's the project I was working on, with the relevant bug report.
> https://github.com/AsteroidOS/libasteroid/issues/13
>
> So can someone verify that:
> 1. the interface is intended to be shared via GATT and Battery1
> 2. that it does not work that way today

Did you check if that was not fixed already? It seems to work alright
with git latest using bluetoothctl:

[NEW] Primary Service (Handle 0x0000)
/org/bluez/hci0/dev_XX_XX_XX_XX_XX_XX/service0020
0000180f-0000-1000-8000-00805f9b34fb
Battery Service


-- 
Luiz Augusto von Dentz