Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6b6ec31f-dfc8-7690-bb38-5c8e12243dc0@googlemail.com>
Date:   Wed, 2 Mar 2022 08:54:17 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: bug kernel 5.17, qualcom and intel adapters, unable to reliably
 connect to bluetooth devices
Content-Language: en-GB
To:     Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc:     Chris Murphy <lists@colorremedies.com>,
        Bluetooth <linux-bluetooth@vger.kernel.org>,
        regressions@lists.linux.dev
References: <CAJCQCtSeUtHCgsHXLGrSTWKmyjaQDbDNpP4rb0i+RE+L2FTXSA@mail.gmail.com>
 <2ce6175c-74ec-8469-80a5-374bd1429542@googlemail.com>
 <CABBYNZJNTOT-mEQe2cfZiEX6A2pR7+sacBqtBRPRZY69YmgtvA@mail.gmail.com>
 <17f2bf7e-1d6b-e090-8926-21a408f2b496@googlemail.com>
 <CABBYNZ+cL4f8xvTJFQGLgqPueE=-UsOtvcPQez0BEsJ5xGppfQ@mail.gmail.com>
 <16cac2c8-c1ca-c8d7-e3d9-5f00be511614@googlemail.com>
 <CABBYNZJQOSZ1fecTRQOX+w8crdiLdr0_tVstgbnyEVq3NaxscQ@mail.gmail.com>
 <6b17bdb5-dddb-e7c7-86f6-2240c6523a81@googlemail.com>
 <CABBYNZ+2Dg+AdnJqpR=wS0juektNapwHcPHBWdZyvSGFT1dVLQ@mail.gmail.com>
 <cdfed116-a5ea-0313-ba87-da429a0ac089@googlemail.com>
 <CABBYNZLnMwod+pgomEfvu83AJ=jM+uqwK9-Eqj6fA9_wXg6HBA@mail.gmail.com>
 <CABBYNZJvQaD4z_pL2YJnu3Ma8MLmxkUqAHMswd8s9XsE5FNMMw@mail.gmail.com>
 <032917a9-0c14-16d3-2751-945b9cd766a3@googlemail.com>
 <CABBYNZKZZT0Wmzx5YfTWSR7_P--O=8QLOdn7jWKa9x=GjYNgzA@mail.gmail.com>
 <CABBYNZJekcb8wy+Sp7pLPs-usvm8yXPqL+e3RCDv5i9S+cq8dQ@mail.gmail.com>
From:   Chris Clayton <chris2553@googlemail.com>
In-Reply-To: <CABBYNZJekcb8wy+Sp7pLPs-usvm8yXPqL+e3RCDv5i9S+cq8dQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 01/03/2022 22:47, Luiz Augusto von Dentz wrote:
> Hi Chris,
> 
> On Tue, Mar 1, 2022 at 2:40 PM Luiz Augusto von Dentz
> <luiz.dentz@gmail.com> wrote:
>>
>> Hi Chris,
>>
>> On Tue, Mar 1, 2022 at 11:40 AM Chris Clayton <chris2553@googlemail.com> wrote:
>>>
>>> Hi
>>>
>>> On 01/03/2022 18:57, Luiz Augusto von Dentz wrote:
>>>> Hi Chris,
>>>>
>>>> On Tue, Mar 1, 2022 at 10:34 AM Luiz Augusto von Dentz
>>>> <luiz.dentz@gmail.com> wrote:
>>>>>
>>>>> Hi Chris,
>>>>>
>>>>> On Tue, Mar 1, 2022 at 1:26 AM Chris Clayton <chris2553@googlemail.com> wrote:
>>>>>>
>>>>>> Hi Luiz,
>>>>>>
>>>>>> I guess you are hoping for PEBKAC :-)
>>>>>>
>>>>>> On 28/02/2022 21:20, Luiz Augusto von Dentz wrote:
>>>>>>> Hi Chris,
>>>>>>>
>>>>>>> On Mon, Feb 28, 2022 at 1:02 PM Chris Clayton <chris2553@googlemail.com> wrote:
>>>>>>>>
>>>>>>>> Hi Luiz,
>>>>>>>>
>>>>>>>> On 28/02/2022 19:34, Luiz Augusto von Dentz wrote:
>>>>>>>>> Hi Chris,
>>>>>>>>>
>>>>>>>>> On Sat, Feb 26, 2022 at 12:04 AM Chris Clayton <chris2553@googlemail.com> wrote:
>>>>>>>>>>
>>>>>>>>>> Hi,
>>>>>>>>>>
>>>>>>>>>> On 24/02/2022 15:16, Luiz Augusto von Dentz wrote:
>>>>>>>>>>>> I'll try another bisection today, but limit its range to changes made in the net/bluetooth directory.
>>>>>>>>>>
>>>>>>>>>> That  bisection has proved very difficult because the bluetooth "service" in kernels at some steps of the bisection were
>>>>>>>>>> completely borked to the extent that blueman's device-manager application wouldn't start and emitted the messages:
>>>>>>>>>>
>>>>>>>>>> blueman-manager 12.00.37 ERROR    Manager:137 on_dbus_name_appeared: Default adapter not found, trying first available.
>>>>>>>>>> blueman-manager 12.00.37 ERROR    Manager:141 on_dbus_name_appeared: No adapter(s) found, exiting
>>>>>>>>>>
>>>>>>>>>> Obviously, I don't know whether the problem I am trying to pinpoint is hiding behind this more fundamental problem with
>>>>>>>>>> the bluetooth "service", so being unable to say whether that kernel was good or bad, I had to skip. There seems to be a
>>>>>>>>>> batch of commits that mean that, whilst the kernel builds okay, hunting down a bluetooth-related problem is not
>>>>>>>>>> possible. Eventually and I cursed and gave up. Whatever was causing this breakage has obviously been fixed.
>>>>>>>>>>
>>>>>>>>>>> Please record the HCI with btmon, it must be producing something since
>>>>>>>>>>> it records even the mgmt commands.
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Refreshed by a good night's sleep, I started another bisection (between 5.16 and 5.17-rc1) yesterday morning but this
>>>>>>>>>> time did not limit it to net/bluetooth.  That was going okay until I ran into what I assume is the same batch of borked
>>>>>>>>>> kernels. I've been more persistent this time but have just had a run of 16 steps in which the bluetooth support in the
>>>>>>>>>> kernel is broken so badly that testing bluetooth is not possible. I will push on today, but I've suspended that activity
>>>>>>>>>> to get the hci trace that Luiz has asked for.
>>>>>>>>>>
>>>>>>>>>> Using information from the bisect, I built a kernel that had tested as bad (but not borked). The commit is
>>>>>>>>>> f2b551fad8d8f2ac5e1f810ad595298381e0b0c5. As I've mentioned before, the problem with devices not connecting is
>>>>>>>>>> intermittent - for a given kernel, sometimes a connection works and other times it doesn't. On the first boot of this
>>>>>>>>>> kernel, my bluetooth devices could connect, Attached are 4 files related to this - the output from btmon, and the
>>>>>>>>>> related portions of daemon.log, kern.log and sys.log from /var/log/. Each of the these files is suffixed with ".good".
>>>>>>>>>>
>>>>>>>>>> I then powered down the laptop and booted into the same kernel. This time the bluetooth devices could not connect. Four
>>>>>>>>>> more files are attached for this boot and are suffixed with ".bad". I said in an earlier email that when connection
>>>>>>>>>> fails, there is no output from btmon, so that log is empty. That's still the case, but I guess that fact itself is a
>>>>>>>>>> clue to what the problem might be. What I can add, however, is that if, in that same bad kernel, I unload and then
>>>>>>>>>> reload the btusb module, connections start to work. Maybe that too is a clue. The same unload/load process revives
>>>>>>>>>> bluetooth on a kernel built after a pull of Linus' latest and greatest this morning.
>>>>>>>>>>
>>>>>>>>>> Since I now have a workround, I'm going stop the current bisection that I was doing.  I've done another couple of steps
>>>>>>>>>> this morning and both produced kernels on which I could not test bluetooth and had to tell git bisect to skip. If
>>>>>>>>>> however, I can provide any other diagnostics, please let me know.
>>>>>>>>>>
>>>>>>>>>> Chris
>>>>>>>>>
>>>>>>>>> Can you try with the following patch:
>>>>>>>>>
>>>>>>>>> https://patchwork.kernel.org/project/bluetooth/patch/20220228173918.524733-1-brian.gix@intel.com/
>>>>>>>>>
>>>>>>>>>
>>>>>>>> Sorry, that patch has made no difference. After the first boot my headphones connected okay, but after a power-down and
>>>>>>>> reboot they would not connect without an unload and reload of the btusb module.
>>>>>>>
>>>>>>> Can you tell us exactly what steps you are using? Are you applying on
>>>>>>> top of what, rc6?
>>>>>>>
>>>>>>
>>>>>> Until I got your patch yesterday, I was using a clone of
>>>>>> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git which I update frequently and have been doing so for as
>>>>>> long as I can remember. Just in case there was a hidden flaw in that tree, I took a new clone yesterday, (so yes, the
>>>>>> patch was tested on top of rc6) copied over the .config file and applied the patch. Then I built and installed the
>>>>>> kernel, updated grub, powered off the laptop and booted into the new kernel. Once the laptop had booted and logged in to
>>>>>> my LXQt desktop, I powered on my headphones and a connection was establisehed almost straight away. I powered the
>>>>>> headphones off and the disconnection worked fine.
>>>>>>
>>>>>> Knowing that the problem crops up intermittently, I then rebooted the laptop. When the boot was complete, I then powered
>>>>>> on my bluetooth headphones an waited for them to connect to the laptop. After about 20 seconds, a connection had not
>>>>>> been established. I powered off the headphones, used modprobe to unload and then reload the btusb module. When I powered
>>>>>> on the headphones, a connectiin was established within 2 or 3 seconds.
>>>>
>>>> Ive attempted 5 restart with 5.17.0-0.rc6.109.fc37.x86_64, my headset
>>>> was able to reconnect every single time without any problem. The only
>>>
>>> For your five tests, did it connect on the first boot? As I've said, sometimes it fails to connect on the first boot,
>>> but if it succeeds, it has always failed after a power-off and restart. Looking back at the notes I took during the
>>> bisect, I've didn't have a single bisection step where I had to boot more more than twice to ascertain that it was a bad
>>> kernel. As I said, I didn't mark a kernel as good until I'd had five successful boots.
>>
>> It did connect every single time.
>>
>>>> normally, once from gdm and then another time when gnome is loading,
>>>> but I assume it is normal nowadays since it appears when switching
>>>> session pipewire unregisters its audio endpoints.
>>>>
>>>
>>> I don't use pipewire. Prior to 5.17, bluetooth has worked more or less trouble free for at least 4 years. I've read
>>> about pipewire in Linux Magazine but don't see what it would bring to my party except complication.
>>>
>>> ends on how bluetoothd is being
>>>> started or something.
>>>>
>>>
>>> Did you see the warnings that read "Bluetooth: hci0: unexpected event 0xff length: 5 > 0"? That seems to indicate that
>>> something is sending events that are unexpected. What effect will that have?  As I said, according to lshw, my system's
>>> bluetooth hardware is Intel AX201. Is that what you are testing on?
>>
>> I have an AX200 on my system, AX201 is very similar so Id be surprised
>> if that is the problem, btw Ive also got some unexpected events but
>> that didn't stop the headset to reconnect.
>>
>>>>>> I've booted this laptop countless times over the last few days. Doing the bisect, I didn't mark a commit as good until I
>>>>>> had done five boots and been able to connect my headphones on each boot. What I can say from that work is that two
>>>>>> consecutive boots into a working kernel are very rare. I can't remeber an occasion when it took more than two boots to
>>>>>> establish that a kernel was bad.
>>>>>
>>>>> Do commands such as bluetoothctl power on or scan on works? Try
>>>>> running bluetoothd -dn from a shell (disable bluetooth.service), also
>>>>> are there any settings changed in main.conf?
>>>>>
>>>
>>> Sorry, I forgot to answer this question earlier. I haven't changed main.conf. Besides, my bluetooth devices connect
>>> successfully every time with 5.16.11 and 5.15.25 kernels. As I've said before, that strongly suggests that there is a
>>> code regression in 5.17.
>>
>> Not saying there isn't something wrong, we have sent a couple of fixes
>> that doesn't seem to be merged yet, and we are working on another one
>> for fixing the scan:
>>
>> https://lore.kernel.org/linux-bluetooth/f648f2e11bb3c2974c32e605a85ac3a9fac944f1.camel@redhat.com/T/
> 
> Btw, are you by any chance doing something like hciconfig hci0 up on
> your init scripts?
> 
Yes , that is included in /etc/init.d/bluetooth.
>>>>>
>>>>> --
>>>>> Luiz Augusto von Dentz
>>>>
>>>>
>>>>
>>
>>
>>
>> --
>> Luiz Augusto von Dentz
> 
> 
>