Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp891242pxp; Wed, 16 Mar 2022 20:21:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw87pNtixJsSF8JVEnWSOBQAgaYaojKrynLmelJNwhPBeDfi5kgcnrMWFScrDmo8Q0J1mTO X-Received: by 2002:a17:902:e552:b0:14f:bfec:eb2c with SMTP id n18-20020a170902e55200b0014fbfeceb2cmr2984842plf.108.1647487300257; Wed, 16 Mar 2022 20:21:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647487300; cv=none; d=google.com; s=arc-20160816; b=chISOZPuim3zyBD8aqwvEB4mIKnjMDBCKNHKNO/GS6BPRxOpUfRFGb1xfkEBi4HTv7 Lv4soirO/WBUeYrJLpqnrMJ+IvVdtFmxS9lB88DesaekwFOPLmssGF3v0S9lchD4/6GO ASOUhY0hOrt/TOo6bgCadRCgDC8xqKNEbC63FhJD6Rdx4+5yVRfiL+MPOgoEsVDVi/dS Cv7ajZNYKmvdcO3TLkojvScDoFOWpkwdpFARofyn3gGV9tcmxsPqoF+5bIDnCm/oAKMb Ho/4T3qIs3CadlaSN+WkdFMuw0rFcQOIBAYQO6tGkd+9uuglXbTHYWin9Q9t3nDCI92/ vSyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=Kn7zZYY5bxL1EpHtVxFGDfqwBmB2NTHpIJ+KYl6AN5k=; b=VGp45yClLLuPNqEqgQ1XEzNZMoDMQTidn5ZVY7a+4w1P86Pe+ug6VF0A1tG4dXmr/g yoI3lSMxLGiRbcg02duU1sEiY3ZBGLO1NOSpBBvPoBYV7B7xfDq63+Wrm/EzX/ac/p2V UAPz9323G3z8kTEmj8b/0aXIC0IzM47IOBs7NgJ96V07SjQnNB+eIpKWTKxaPJM/YODR p+681jMC6XowLazqOkjWy6iFl/nP2IfpuWoJhEspR/Je36NbK5W4vnl3Jf13z1RGaiwZ lwYdpV0r5+zvQjX4G115M8og/fIrh9igNuMUDUJ5MUjRUTouihzCej5aalhoa2lqh/9k h6gg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Tc3GjVj4; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id d9-20020a056a00198900b004f7a6d338c9si3852184pfl.70.2022.03.16.20.21.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Mar 2022 20:21:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Tc3GjVj4; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5B14026AF1; Wed, 16 Mar 2022 20:21:30 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354128AbiCPPl2 (ORCPT + 99 others); Wed, 16 Mar 2022 11:41:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348907AbiCPPl1 (ORCPT ); Wed, 16 Mar 2022 11:41:27 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4FD274AE15 for ; Wed, 16 Mar 2022 08:40:13 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0552EB81C17 for ; Wed, 16 Mar 2022 15:40:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id CAC65C340F0; Wed, 16 Mar 2022 15:40:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1647445210; bh=giNVwsZZkAoJvfFKgYXXYGqfH/9jALxusLjdP7i5fOY=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=Tc3GjVj4FxawKgExogY/+8l02v3zA++7T60oKQJqHbKsQuRoQHM3Sm5EbbDr7R31+ kTurFtvYfYG6rVQoE1Ee4uwOW3rgxFy052m4RThVx/HWaEhGppAE+SXJwefaB6+Yo4 1VyDcIrxlhhYhNSFfzJ+GpjxgHxGYF1JyHgBrprTjHNJ4XjcvsHG8zzb7o33ADaEvt BtTlSw05nspTnmqbnXTifrGXZdJQyD9UEHm6ijZIQsRDadfoHP/0ngMMaE9W5FlxTh PzlsZsppqzd+PSMCmNTFO+vGUma+aO1Tp2nf+4F06+gyDRoY/GmVFwT3zedgTdr3i4 fcrcboesqeVWA== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id AFB58E6BBCA; Wed, 16 Mar 2022 15:40:10 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] Bluetooth: call hci_le_conn_failed with hdev lock in hci_le_conn_failed From: patchwork-bot+bluetooth@kernel.org Message-Id: <164744521071.701.7551558981084729943.git-patchwork-notify@kernel.org> Date: Wed, 16 Mar 2022 15:40:10 +0000 References: <20220316153350.10047-1-dossche.niels@gmail.com> In-Reply-To: <20220316153350.10047-1-dossche.niels@gmail.com> To: Niels Dossche Cc: linux-bluetooth@vger.kernel.org, marcel@holtmann.org, johan.hedberg@gmail.com, luiz.dentz@gmail.com X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hello: This patch was applied to bluetooth/bluetooth-next.git (master) by Marcel Holtmann : On Wed, 16 Mar 2022 16:33:50 +0100 you wrote: > hci_le_conn_failed function's documentation says that the caller must > hold hdev->lock. The only callsite that does not hold that lock is > hci_le_conn_failed. The other 3 callsites hold the hdev->lock very > locally. The solution is to hold the lock during the call to > hci_le_conn_failed. > > Fixes: 3c857757ef6e ("Bluetooth: Add directed advertising support through connect()") > Signed-off-by: Niels Dossche > > [...] Here is the summary with links: - Bluetooth: call hci_le_conn_failed with hdev lock in hci_le_conn_failed https://git.kernel.org/bluetooth/bluetooth-next/c/7c686a32a512 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html