Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 17 Mar 2022 10:57:40 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Sean Wang <sean.wang@mediatek.com>
Cc:     Marcel Holtmann <marcel@holtmann.org>,
        Johan Hedberg <johan.hedberg@gmail.com>,
        Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        linux-bluetooth@vger.kernel.org,
        linux-mediatek@lists.infradead.org, kernel-janitors@vger.kernel.org
Subject: [PATCH] Bluetooth: btmtkuart: fix error handling in
 mtk_hci_wmt_sync()
Message-ID: <20220317075740.GE25237@kili>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.10.1 (2018-07-13)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dH5gk+YJZc6KaRTocW7qXyoa6uSTWmbBwxtCsybt8JqhlrJVhZz+aXLt4I3J?=
 =?us-ascii?Q?a5ygl0NIjKtFNdbAIZTPAp54r2pjj3PhhhHZuXxqXhz5EUggqidqS+PQpIae?=
 =?us-ascii?Q?nxCXXUWkC86JV7ROqv77vLAAe/zY9tOZbhh2rOSr6yRNej7hmLYIys8TlVlJ?=
 =?us-ascii?Q?hSQYSp01Ha7COXVrS8kU9FZYGWYXxnkM/zXgTcl/SSxlrYEK7P5zD1JGOyDg?=
 =?us-ascii?Q?XaIaaV/V3Lg8h52d8QU3kultCnojQYk1kN0l8z2oV/8ngqvYUHV0PmvkEM5E?=
 =?us-ascii?Q?PeqSc3yNb2DV3Bs2IJi/NyG5sf1t7pQ2zMFN4BPO+htrZzkAK+jymadh6ICj?=
 =?us-ascii?Q?49BDI+aE7+BgdTDsmWuqoU5+UEO4run2GjBarefBsXJG+Nsm45zarMHkAUT9?=
 =?us-ascii?Q?hMM1rG6RH3MosFRKtXcZIcbeuv5xYWPeWucduW56kGb2YU23rpElPUuHWUJu?=
 =?us-ascii?Q?h7YICoX7vxW26FdqzBSGTAGM77jwTZRhJ4BkW+xjZakUuNw9XySd6MQAQTf/?=
 =?us-ascii?Q?YJU+RhQIwzjrrB+OACiWBWhvEoNWLQ2EYINldrB52M13GXGwVmVcb4P0p5Bc?=
 =?us-ascii?Q?ZlXbuhn9V9LJ3fEu37UHsoQLMtPlgn2PD0849wn7CCCWkkMcEgTrkYUe4lfl?=
 =?us-ascii?Q?4Sn59wG8ODiRt34yf2Hdlw1kbQIFm3/ojasSWVvHsryJYWPA1E9QIQ8Iusus?=
 =?us-ascii?Q?1mQCFZs+ELuEoGHaYlr3SRK1F7/42cTTjfhwo/N0Et3J/q8NFuB4OOLjrvGP?=
 =?us-ascii?Q?r+xzk9d5NwvlwxOq87NhtMO7+JJnMSTlFmOOMpHejlJp3KGEDb8hyHr+Ctcu?=
 =?us-ascii?Q?iLFXQIHBLMjpL7y5UdSGgxm//9BoTI6U22yl1QCbXvtl613zOETmBFqn7QRn?=
 =?us-ascii?Q?DbIg2n63q0ZiSyYFuOEdTT028/L6j4Kjtgu2ZEkTdf8HD5KeXjHvR5VKs6+g?=
 =?us-ascii?Q?OzZOz41QpZja0MOvsn/eSWD8Nxv9EHrtGD+a6OLSXMF73deimPCjnaRJu1DQ?=
 =?us-ascii?Q?HDq2ajltAQYOBt+bnZLUtZmt37W8VbZWaG/L1mtp6HjDL30gLSlIDugzZJAt?=
 =?us-ascii?Q?L806p7db2yUOCPJABd0YyhIOzqsdSqVnHj/bdh4Of0mHf0MiiKsPYyOWxZrg?=
 =?us-ascii?Q?W3DVNuVkDCTFm5zJi37T3z8xQ7G+cvVqoIeX1wIwO/HMrMs1gNz89xJPwSJ5?=
 =?us-ascii?Q?P/4bePG4F9CxkKb67ixeBbXiSmw3jBdDHm9x/Vi63LHCVCbK+VR6QjS3kRyH?=
 =?us-ascii?Q?8Fj9hLJJZlCluoJ6RaV8/JkTc8PsKo0N1OmjyT+xdtO/9kElJoWWg7Rabnle?=
 =?us-ascii?Q?K2079xCLX0QRKYTd03z2wft0bjZGn+tPAFQPYqgdNj/owLrl3PRpq2mS1Pqh?=
 =?us-ascii?Q?o2+cMwYrZDyyjrbMVBh0xz/S4GrX/kLaSwbWaipXQkdRPKA9uZ6hFpI3et4a?=
 =?us-ascii?Q?5lRv3FaSe5levq9LjezbqKFKffXfqTidtjmEzc2aoukLsAhu/qw/4Q=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b6a5e1ad-8742-442c-d286-08da07ebd5cb
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2022 07:57:51.3053
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Djw8bGDmMwnmWWH7Nv00g2ciLhhfaZgdXhXI+X3bqsSySyJ1SJkbiznDoDsyrXB4gjYjxTGF/MvKHmatlcTIh57KuHjGDhDQcAgs78jvLso=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5390
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10288 signatures=693715
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0
 malwarescore=0 mlxscore=0 suspectscore=0 spamscore=0 bulkscore=0
 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2203170046
X-Proofpoint-GUID: cm8RZROjrhZRLfLAS3R4E4rYWPSVjjZu
X-Proofpoint-ORIG-GUID: cm8RZROjrhZRLfLAS3R4E4rYWPSVjjZu
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

This code has an uninitialized variable warning:

    drivers/bluetooth/btmtkuart.c:184 mtk_hci_wmt_sync()
    error: uninitialized symbol 'wc'.

But it also has error paths which have memory leaks.

Fixes: 8f550f55b155 ("Bluetooth: btmtkuart: rely on BT_MTK module")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/bluetooth/btmtkuart.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/drivers/bluetooth/btmtkuart.c b/drivers/bluetooth/btmtkuart.c
index 695e1225b08c..c98691cdbbd5 100644
--- a/drivers/bluetooth/btmtkuart.c
+++ b/drivers/bluetooth/btmtkuart.c
@@ -105,8 +105,10 @@ static int mtk_hci_wmt_sync(struct hci_dev *hdev,
 	}
 
 	wc = kzalloc(hlen, GFP_KERNEL);
-	if (!wc)
-		return -ENOMEM;
+	if (!wc) {
+		err = -ENOMEM;
+		goto err_free_skb;
+	}
 
 	hdr = &wc->hdr;
 	hdr->dir = 1;
@@ -153,7 +155,7 @@ static int mtk_hci_wmt_sync(struct hci_dev *hdev,
 		bt_dev_err(hdev, "Wrong op received %d expected %d",
 			   wmt_evt->whdr.op, hdr->op);
 		err = -EIO;
-		goto err_free_skb;
+		goto err_free_wc;
 	}
 
 	switch (wmt_evt->whdr.op) {
@@ -177,11 +179,11 @@ static int mtk_hci_wmt_sync(struct hci_dev *hdev,
 	if (wmt_params->status)
 		*wmt_params->status = status;
 
+err_free_wc:
+	kfree(wc);
 err_free_skb:
 	kfree_skb(bdev->evt_skb);
 	bdev->evt_skb = NULL;
-err_free_wc:
-	kfree(wc);
 
 	return err;
 }
-- 
2.20.1