Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp1239487pxp; Thu, 17 Mar 2022 05:58:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzdPM/j/Jw9eCaqn3ryLX5QlJzcCPeY7s6NJcfN7VG1CNsmYW7hJxVxT5fr23BjYytR/nWs X-Received: by 2002:a17:902:cec2:b0:151:b337:a699 with SMTP id d2-20020a170902cec200b00151b337a699mr5094875plg.59.1647521921986; Thu, 17 Mar 2022 05:58:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1647521921; cv=none; d=google.com; s=arc-20160816; b=RXW4QdSNICcqK2FJWlmpb4CXRkcXRrU2rjlQ0ZJXZ8UCDzeA6p8UwtY6cQq4ppUIlo BinPBhDpkvpaaJoGDFQOcrYgZo71BzmR/pmFWIeKUzAfbARbdoOruEUDJNgghkFy6oL8 7csj/oaGaoL22Pj44X9/nxGq3bG2oSRAoFq2cTfpC7xbCsgx56F6H6QC8teX9yTpB2i1 BXPaPBDcdVFmgzSZVdaEsuIU3k1aItjMlHADUHChHko/5BobrUsjcGIpM/deBrLa6L3Y cY0mCDhyabl8rQB6Y75vms9rmBW2MYeTbGE2kWU+WCmptC0DyrzxGpqfrcdHibwWcXGt pDpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version; bh=zqArGf0ZGdri0TNEykctU6Pbj4ePehFPte54VtG5BW8=; b=NBogF/MHKQroFoWFEkzgXJXQtok2BJ6pJ1HHq2TnfToSAThnL13RY/F64hoN2q0EtG 43at7BR4OgftY7B5X+KiaNN04svFW0NXpEd8HGn/i6zQKt+GBF9XVca3b4iAi1J43Izv DYkkmp5wmJ4bFiZEvkydPPD+mmkv10ypvWKFJ+qYcgeM/f/EKvYFAVpJ6dddFWxjEQSU rM5HKYoIENp036N+Qq39xKZEYOBr78ZPiwvD+6TBT78N/K/o7oLAGXSQ6fQMvwL9ztUs BfbjEsP8PYswhNLbY/wvR2OvPkQhvjeobGn7hRaW69hSw+oq2SzX7wqwo88Elde/gcfw HJ/Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u136-20020a63798e000000b003816043efb7si2077749pgc.428.2022.03.17.05.58.14; Thu, 17 Mar 2022 05:58:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231792AbiCQLNn (ORCPT + 99 others); Thu, 17 Mar 2022 07:13:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231295AbiCQLNn (ORCPT ); Thu, 17 Mar 2022 07:13:43 -0400 Received: from mail.holtmann.org (coyote.holtmann.net [212.227.132.17]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7DB9F1E31AF; Thu, 17 Mar 2022 04:12:26 -0700 (PDT) Received: from smtpclient.apple (p5b3d2183.dip0.t-ipconnect.de [91.61.33.131]) by mail.holtmann.org (Postfix) with ESMTPSA id 63425CED0B; Thu, 17 Mar 2022 12:12:25 +0100 (CET) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\)) Subject: Re: [PATCH] Bluetooth: btmtkuart: fix error handling in mtk_hci_wmt_sync() From: Marcel Holtmann In-Reply-To: <20220317075740.GE25237@kili> Date: Thu, 17 Mar 2022 12:12:24 +0100 Cc: Sean Wang , Johan Hedberg , Luiz Augusto von Dentz , Matthias Brugger , BlueZ , linux-mediatek@lists.infradead.org, kernel-janitors@vger.kernel.org Content-Transfer-Encoding: 7bit Message-Id: References: <20220317075740.GE25237@kili> To: Dan Carpenter X-Mailer: Apple Mail (2.3696.80.82.1.1) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Dan, > This code has an uninitialized variable warning: > > drivers/bluetooth/btmtkuart.c:184 mtk_hci_wmt_sync() > error: uninitialized symbol 'wc'. > > But it also has error paths which have memory leaks. > > Fixes: 8f550f55b155 ("Bluetooth: btmtkuart: rely on BT_MTK module") > Signed-off-by: Dan Carpenter > --- > drivers/bluetooth/btmtkuart.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel