Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c33b9cf1-7805-b318-c246-fba441d20ffc@molgen.mpg.de>
Date:   Mon, 21 Mar 2022 05:31:33 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [BlueZ PATCH 5/9] monitor: Display AdvMonitor DeviceFound/Lost
 events
Content-Language: en-US
To:     Manish Mandlik <mmandlik@google.com>
Cc:     marcel@holtmann.org, luiz.dentz@gmail.com,
        chromeos-bluetooth-upstreaming@chromium.org,
        linux-bluetooth@vger.kernel.org,
        Miao-chen Chou <mcchou@chromium.org>
References: <20220320183445.BlueZ.1.I21d5ed25e9a0a2427bddbd6d4ec04d80d735fc53@changeid>
 <20220320183445.BlueZ.5.I53ad1b66c8f8a65e5950354cd20417d812ad9c72@changeid>
From:   Paul Menzel <pmenzel@molgen.mpg.de>
In-Reply-To: <20220320183445.BlueZ.5.I53ad1b66c8f8a65e5950354cd20417d812ad9c72@changeid>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Dear Manish,


Thank you for the patch.

Am 21.03.22 um 02:36 schrieb Manish Mandlik:
> Display information about MGMT_EV_ADV_MONITOR_DEVICE_FOUND and
> MGMT_EV_ADV_MONITOR_DEVICE_LOST events in the btmon output.

If you should reroll this patch, could you please add example messages 
to the commit message?


Kind regards,

Paul


> Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
> ---
> 
>   monitor/packet.c | 29 +++++++++++++++++++++++++++++
>   1 file changed, 29 insertions(+)
> 
> diff --git a/monitor/packet.c b/monitor/packet.c
> index b7431b57d..6f615f7ba 100644
> --- a/monitor/packet.c
> +++ b/monitor/packet.c
> @@ -14103,6 +14103,31 @@ static void mgmt_device_found_evt(const void *data, uint16_t size)
>   	print_eir(data + 14, size - 14, false);
>   }
>   
> +static void mgmt_adv_monitor_device_found_evt(const void *data, uint16_t size)
> +{
> +	uint16_t handle = get_le16(data);
> +	uint8_t address_type = get_u8(data + 8);
> +	int8_t rssi = get_s8(data + 9);
> +	uint32_t flags = get_le32(data + 10);
> +	uint16_t data_len = get_le16(data + 14);
> +
> +	print_field("Handle: %u", handle);
> +	mgmt_print_address(data + 2, address_type);
> +	print_rssi(rssi);
> +	mgmt_print_device_flags(flags);
> +	print_field("Data length: %u", data_len);
> +	print_eir(data + 16, size - 16, false);
> +}
> +
> +static void mgmt_adv_monitor_device_lost_evt(const void *data, uint16_t size)
> +{
> +	uint16_t handle = get_le16(data);
> +	uint8_t address_type = get_u8(data + 8);
> +
> +	print_field("Handle: %u", handle);
> +	mgmt_print_address(data + 2, address_type);
> +}
> +
>   static void mgmt_discovering_evt(const void *data, uint16_t size)
>   {
>   	uint8_t type = get_u8(data);
> @@ -14414,6 +14439,10 @@ static const struct mgmt_data mgmt_event_table[] = {
>   			mgmt_controller_suspend_evt, 1, true },
>   	{ 0x002e, "Controller Resumed",
>   			mgmt_controller_resume_evt, 8, true },
> +	{ 0x002f, "Adv Monitor Device Found",
> +			mgmt_adv_monitor_device_found_evt, 16, false },
> +	{ 0x0030, "Adv Monitor Device Lost",
> +			mgmt_adv_monitor_device_lost_evt, 9, true },
>   	{ }
>   };
>