Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 23 Mar 2022 10:48:30 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Marcel Holtmann <marcel@holtmann.org>,
        Yake Yang <yake.yang@mediatek.com>
Cc:     Johan Hedberg <johan.hedberg@gmail.com>,
        Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Sean Wang <sean.wang@mediatek.com>,
        Mark Chen <markyawenchen@gmail.com>,
        linux-bluetooth@vger.kernel.org,
        linux-mediatek@lists.infradead.org, kernel-janitors@vger.kernel.org
Subject: [PATCH] Bluetooth: mt7921s: fix a NULL check
Message-ID: <20220323074830.GA4639@kili>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.10.1 (2018-07-13)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?iFaW9t7v8UfXaEYsu2CAi//HAmlihBKXa3VxiQN6tz07cM9h9GA+Po02e/To?=
 =?us-ascii?Q?/o+ah5ODYpnDv18YP2VktU2kcRiByiRVwi8i7cEj7I42jJduCnfj6E/vkmbd?=
 =?us-ascii?Q?Z/hEyyNMnSzvo7sAoSoMn1aIikdJZyQ1+Gr6wSipMv0n/1TTS3IDbg258kHF?=
 =?us-ascii?Q?kyudEgaREeUX2ZDSOlsjvC8CNF+ejy4wH5SDURp6DHMCp3QVfYeVAIrxIvF4?=
 =?us-ascii?Q?GbBUwEMzBWn+6YoW+R+2nZYL1O1l8hVnSxZXlJrqJqWTF0EFfR420cCkGgiO?=
 =?us-ascii?Q?WXdS0hKkNIFR2EomqP6G6zQglFpRJjFqY/mvZ23sOhTt9bZwMGqlb1FA37mK?=
 =?us-ascii?Q?qz21QWPgMpEigDuSlrUN0Fd/ExdbhvtqhswxGvKwuGN3MQhWMDI3wDxc2AUN?=
 =?us-ascii?Q?/tYdKoMbxvzX9YFKeE+XTm8Eg+4u/UudAHgopNPGbdBzWqjzizDVpvbtqdSQ?=
 =?us-ascii?Q?YHb5+SLHlg82z0w31fPQsBgH3aR4HCCJxPpA0XjnfrMIifmaUUH1jlQQusG9?=
 =?us-ascii?Q?78VyzQrA/TQri+iGzsQf/sP22x3SlYFgGA70k7HFFhGbNkzxK8adQ/7GGZom?=
 =?us-ascii?Q?dAwKlM0AJp6Z4ZKcFy7HYjiGUAxkyAOr59q+xJClFGq9LFT/aI9UIHawtuzG?=
 =?us-ascii?Q?EqSdMsj8VOUO2XfcgpiGKEHP2f3Ro+1P1A/gT56d+cGLnDAMVn4tbytq1kgs?=
 =?us-ascii?Q?3HFuwI7iJgGp7Y7kElupXHiasbUf9GI3Silk5gS4EeGqgoml57faHIsNIQde?=
 =?us-ascii?Q?mCyZSnCBOgeK4pj/wevzjAjJZjdb88kNwIe24gjrbFyxCpb8Ik2hYsyEEOUp?=
 =?us-ascii?Q?l+ksDmpj4u1XLkBv335g/so5rpYflav5loBenEuT2YnV88XvtTEkH4KeJehK?=
 =?us-ascii?Q?NQ5X292T+SmhTX3Ab7egCnQoFZXUfLasVyJjOCyQBdCV4gNow2pP0tMsB3qf?=
 =?us-ascii?Q?B3bTdqVXMUspZnH+jF2DjZgHVJiaQOiAthjSFkp42ZY6XcgWMjO6vIm/OSQU?=
 =?us-ascii?Q?jm54k8+OmKidSygUAJPc+pk6DsOr6rcRFeXFrgNP6pr9d7LsCoHTZRQ5S40i?=
 =?us-ascii?Q?2blguNygUCKKSyoq64di9T7ZRQZb7wOHAtTNVcDxNymMR9foMJQ9ZKG5nX4Q?=
 =?us-ascii?Q?Xn7M8Mv5OHkvMzB63Wm0+eILAqSdY9DpWFWQIKA5kPQFZOT4X6xvzHWh+5jF?=
 =?us-ascii?Q?BE6D2s5lAVdTBvogzRVy0Svfwl9JKD1eYU3deCLmWAyTQZhoxB29uIgJdlWm?=
 =?us-ascii?Q?NVm8zq4XzjTovSpLugOio08sWAU3CAc2S2U1unqBy/zNZ7RG8LTrHGz0wiRO?=
 =?us-ascii?Q?acywBbgfzsZ1hPiVMJLrlz+esmeFstvIkADvW+8fDhB8kq0HpKGFTRmwLSz3?=
 =?us-ascii?Q?M+0nbn0mB0RcCqFaHnSklrEh9kPM+yOdAH/K8Ml+AhhjeEv7ds2qwvOrhPoO?=
 =?us-ascii?Q?U3A6djzYnbwQb4GoEdUwRn9dWnDBpseyPKhsy1ZuTCjBSTTl/vPzFw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f92ca621-7ae6-4dfc-f681-08da0ca18dfe
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2022 07:48:44.1192
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: w9AXjCQgvaCAuQl8A4xer2o0Rhu1fhNiktcDLkG8IMXTQIDpn3IZUtqAhhoFP15qgtemZ9EpWBYw1MsvyN04Z5UHv1DB8ROHhxyQ/CC6L5A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR10MB3069
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10294 signatures=694350
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 mlxscore=0
 bulkscore=0 phishscore=0 spamscore=0 mlxlogscore=999 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2203230044
X-Proofpoint-GUID: DzpnsihYkqdV7bKMSW1ENINv3LnSFpCE
X-Proofpoint-ORIG-GUID: DzpnsihYkqdV7bKMSW1ENINv3LnSFpCE
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

There is a typo in the NULL check so it's never true.  It should be
checking "*ven_data" instead of "ven_data".

Fixes: 3cabc5ca2c9d ("Bluetooth: mt7921s: Add .btmtk_get_codec_config_data")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/bluetooth/btmtksdio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bluetooth/btmtksdio.c b/drivers/bluetooth/btmtksdio.c
index f3dc5881fff7..b6d77e04240c 100644
--- a/drivers/bluetooth/btmtksdio.c
+++ b/drivers/bluetooth/btmtksdio.c
@@ -961,7 +961,7 @@ static int btmtksdio_get_codec_config_data(struct hci_dev *hdev,
 	}
 
 	*ven_data = kmalloc(sizeof(__u8), GFP_KERNEL);
-	if (!ven_data) {
+	if (!*ven_data) {
 		err = -ENOMEM;
 		goto error;
 	}
-- 
2.20.1