Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <805b3f2f-3537-b8e0-2709-325041d7c98c@molgen.mpg.de>
Date:   Sat, 9 Apr 2022 13:36:34 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH BlueZ 1/1] adapter: Fix check of DISCOVERABLE setting
Content-Language: en-US
To:     Jakob Hilmer <jakob@hilmer.dk>
References: <20220409100130.9743-1-jakob@hilmer.dk>
 <20220409100130.9743-2-jakob@hilmer.dk>
Cc:     linux-bluetooth@vger.kernel.org
From:   Paul Menzel <pmenzel@molgen.mpg.de>
In-Reply-To: <20220409100130.9743-2-jakob@hilmer.dk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Dear Jakob,


Am 09.04.22 um 12:01 schrieb Jakob Hilmer:
> From: Jakob hilmer <jakob@hilmer.dk>

*H*ilmer?

> The test for `DISCOVERABLE` should be done with
> `MGMT_SETTING_DISCOVERABLE` instead of `MGMT_OP_SET_DISCOVERABLE`.
> ---
>   src/adapter.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/adapter.c b/src/adapter.c
> index 71de9e82b..f1197684e 100644
> --- a/src/adapter.c
> +++ b/src/adapter.c
> @@ -1993,7 +1993,7 @@ static bool set_discovery_discoverable(struct btd_adapter *adapter, bool enable)
>   		return true;
>   
>   	/* Reset discoverable filter if already set */
> -	if (enable && (adapter->current_settings & MGMT_OP_SET_DISCOVERABLE))
> +	if (enable && (adapter->current_settings & MGMT_SETTING_DISCOVERABLE))
>   		return true;
>   
>   	adapter->discovery_discoverable = enable;
> @@ -2229,7 +2229,7 @@ static int update_discovery_filter(struct btd_adapter *adapter)
>   	/* Only attempt to overwrite current discoverable setting when not
>   	 * discoverable.
>   	 */
> -	if (!(adapter->current_settings & MGMT_OP_SET_DISCOVERABLE)) {
> +	if (!(adapter->current_settings & MGMT_SETTING_DISCOVERABLE)) {
>   		GSList *l;
>   
>   		for (l = adapter->discovery_list; l; l = g_slist_next(l)) {

Acked-by: Paul Menzel <pmenzel@molgen.mpg.de>


Kind regards,

Paul