Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b31674e7-f05b-2acc-109c-23e0597307ea@molgen.mpg.de>
Date:   Tue, 12 Apr 2022 07:28:31 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH BlueZ] btdev: Fix not cleanup ssp_status and
 ssp_auto_complete
Content-Language: en-US
To:     Luiz Augusto von Dentz <luiz.dentz@gmail.com>
References: <20220411235804.3776702-1-luiz.dentz@gmail.com>
Cc:     linux-bluetooth@vger.kernel.org
From:   Paul Menzel <pmenzel@molgen.mpg.de>
In-Reply-To: <20220411235804.3776702-1-luiz.dentz@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Dear Luiz,


Thank you for your patch.

Am 12.04.22 um 01:58 schrieb Luiz Augusto von Dentz:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> This fixes not clenup ssp_status and ssp_auto_complete flags on

cle*a*nup

> auth_complete.

I’d just write:

Clean up ssp_status and ssp_auto_complete flags on auth_complete

(Same for the commit message summary.)

> ---
>   emulator/btdev.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/emulator/btdev.c b/emulator/btdev.c
> index f70fa9136..ccfaed36b 100644
> --- a/emulator/btdev.c
> +++ b/emulator/btdev.c
> @@ -1366,6 +1366,11 @@ static void auth_complete(struct btdev_conn *conn, uint8_t status)
>   	ev.status = status;
>   
>   	send_event(conn->dev, BT_HCI_EVT_AUTH_COMPLETE, &ev, sizeof(ev));
> +
> +	conn->dev->ssp_status = 0;
> +	conn->dev->ssp_auth_complete = false;
> +	conn->link->dev->ssp_status = 0;
> +	conn->link->dev->ssp_auth_complete = false;
>   }
>   
>   static int cmd_link_key_reply_complete(struct btdev *dev, const void *data,

Acked-by: Paul Menzel <pmenzel@molgen.mpg.de>


Kind regards,

Paul