Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220413222425.187199-1-luiz.dentz@gmail.com> <61417C2F-0009-4123-8F1C-DACC4A46073D@holtmann.org>
In-Reply-To: <61417C2F-0009-4123-8F1C-DACC4A46073D@holtmann.org>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Tue, 19 Apr 2022 10:52:15 -0700
Message-ID: <CABBYNZKt+rT5nR2yJeGOTa8wOK84qCVE-6C8X3rQPdqWxBfYmQ@mail.gmail.com>
Subject: Re: [PATCH BlueZ] policy: Change AutoEnable default to true
To:     Marcel Holtmann <marcel@holtmann.org>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Marcel,

On Tue, Apr 19, 2022 at 1:48 AM Marcel Holtmann <marcel@holtmann.org> wrote=
:
>
> Hi Luiz,
>
> > This changes the default of AutoEnable to true so controllers are power
> > up by default.
> >
> > Fixes: https://github.com/bluez/bluez/issues/328
> > ---
> > plugins/policy.c | 6 +++++-
> > src/main.conf    | 4 ++--
> > 2 files changed, 7 insertions(+), 3 deletions(-)
> >
> > diff --git a/plugins/policy.c b/plugins/policy.c
> > index 48f5db7d3..0bbdbfc88 100644
> > --- a/plugins/policy.c
> > +++ b/plugins/policy.c
> > @@ -892,7 +892,11 @@ static int policy_init(void)
> >       }
> >
> >       auto_enable =3D g_key_file_get_boolean(conf, "Policy", "AutoEnabl=
e",
> > -                                                                     N=
ULL);
> > +                                                             &gerr);
> > +     if (gerr) {
> > +             g_clear_error(&gerr);
> > +             auto_enable =3D true;
> > +     }
> >
> >       resume_delay =3D g_key_file_get_integer(
> >                       conf, "Policy", "ResumeDelay", &gerr);
> > diff --git a/src/main.conf b/src/main.conf
> > index 401796235..91b98b8c4 100644
> > --- a/src/main.conf
> > +++ b/src/main.conf
> > @@ -276,8 +276,8 @@
> >
> > # AutoEnable defines option to enable all controllers when they are fou=
nd.
> > # This includes adapters present on start as well as adapters that are =
plugged
> > -# in later on. Defaults to 'false'.
> > -#AutoEnable=3Dfalse
> > +# in later on. Defaults to 'true'.
> > +#AutoEnable=3Dtrue
>
> so this is problematic since all wireless technology daemon where design =
to not automatically activate their hardware. It needed a system above like=
 ConnMan, NetworkManager or even the UI to start the operation.
>
> It is especially tricky since bluetoothd doesn=E2=80=99t remember the las=
t state. So if you power off, then restart, it is on again the next time ar=
ound. Not something you might have wanted. Using false here is the right ch=
oice as a default.
>
> If you install systemd-rfkill and want to auto-power once soft-rfkill is =
released and systemd-rfkill remembers the state persistently, then you need=
 to install your main.conf with AutoEnable=3Dtrue. That is a distro choice.

The argument was that nowadays most systems ship with systemd-rfkill
so having AutoEnable=3Dtrue is much more common than the old default,
perhaps we could detect if the system has systemd-rfkill than we
default to AutoEnable=3Dtrue automatically, does this sound better to
you?

> Regards
>
> Marcel
>


--=20
Luiz Augusto von Dentz