Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8f12681aea9335dd83d104b9930a1e276905f05e.camel@hadess.net>
Subject: Re: [PATCH v2 BlueZ 3/3] build: Make use of StateDirectory and
 ConfigurationDirectory
From:   Bastien Nocera <hadess@hadess.net>
To:     Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Date:   Wed, 20 Apr 2022 10:54:57 +0200
In-Reply-To: <CABBYNZJmGGSZbWZ1=aYkAt6yFo=uP_760mHt_-nq8TeYEbRiBg@mail.gmail.com>
References: <20220415223049.1155838-1-luiz.dentz@gmail.com>
         <20220415223049.1155838-3-luiz.dentz@gmail.com>
         <7222b71167dd3ec90d7b4ad1b12b6179cc95f94d.camel@hadess.net>
         <CABBYNZJmGGSZbWZ1=aYkAt6yFo=uP_760mHt_-nq8TeYEbRiBg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
User-Agent: Evolution 3.44.0 (3.44.0-1.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2022-04-19 at 11:40 -0700, Luiz Augusto von Dentz wrote:
> Hi Bastien,
> 
> On Tue, Apr 19, 2022 at 3:33 AM Bastien Nocera <hadess@hadess.net>
> wrote:
> > 
> > On Fri, 2022-04-15 at 15:30 -0700, Luiz Augusto von Dentz wrote:
> > > From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> > > 
> > > This makes use of StateDirectory[1] and ConfigurationDirectory[1]
> > > to
> > > inform systemd what those paths are used for instead of using
> > > ReadWritePaths and ReadOnlyPaths which can lead to issues.
> > > 
> > > Fixes: https://github.com/bluez/bluez/issues/329
> > 
> > FYI, my reviews on those patches are at:
> > https://github.com/bluez/bluez/issues/329#issuecomment-1102459104
> > 
> > Cheers
> 
> Ive sent a couple of patches addressing them, please have a look.

Patches look good, thanks!