Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp928207pxb; Fri, 22 Apr 2022 14:33:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzg7XJHdlmpevzW2iQ6eVGoEWXqdJTMxC8okVo0uqxlCwob/KXgJfTykwEbxrE8ORjRy2So X-Received: by 2002:a05:6a00:84e:b0:50a:7a43:a2d1 with SMTP id q14-20020a056a00084e00b0050a7a43a2d1mr6860292pfk.51.1650663212021; Fri, 22 Apr 2022 14:33:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650663212; cv=none; d=google.com; s=arc-20160816; b=ALDSnOkryU/7P7mT4mtEEsH0fzB39fclei3jNiH6+wFxLhspNXFdYalcTzg35LJ/+7 J4D8CJ0yqVrjU8FsCiq6tvKUMcvQkwdWcg+HfWmUXQrAG6GQefZGY5Rbk1pK2st65feb WcfUCAli1QvSrJeDv+Lf7TeithMao+NogmI11KId8+a97U82mQwDpdWLCwH1o+kqYKe0 mQklNgWfFMVbzhAnh4KPOynxsnPqK5xm68S3995g4bAwNOcu8/3nQGC0mGcoOoVcOU7w Unu1PEtgmNPieCfwMqU206l11/U1/hpFm41Y8AaMJ88S7e0xI+NexiaahzSvo+TDfYkW bLbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=AlN2Yt1ZtiQmyJVX5MmmEqXpS1avaZvk7LYqa7nqhh0=; b=mePx1TKw9AhDLUV070zYk1+Q8Q8Mvbsau+fUxidBOk8GJfeB8IKySqV0BbShNI1BOP z3ckdb0G3KDavpbbFXHnl5LS1pxiLuZBlDbuIyt441SdHs0d8V1zjMrvBNQNkpO0gBpi 25cbjLqoHmD386xYJrYydcy3oecIIaGJNuN5n733RT8A81Q5xkfagEg/AHGlxHQ4eJjg z9R6+qHJrwYl88GEczJg1/ISYzqJDXGHJNu5lvti5v9iTV6OSjh+39MPnYeLx1LThFBU RHuRFo+urC4/rv59O11dJa8BYela16tOdQ9aPfOs+zC3qw+qtJ9Vlnpu15WPWgXUZqC3 TtGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="sbWaq/+h"; spf=softfail (google.com: domain of transitioning linux-bluetooth-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id i8-20020a056a00224800b004fae16c6a7fsi8040234pfu.167.2022.04.22.14.33.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 14:33:32 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-bluetooth-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="sbWaq/+h"; spf=softfail (google.com: domain of transitioning linux-bluetooth-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C99EF2F2074; Fri, 22 Apr 2022 12:41:02 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1445863AbiDVJdL (ORCPT + 99 others); Fri, 22 Apr 2022 05:33:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1446108AbiDVJdI (ORCPT ); Fri, 22 Apr 2022 05:33:08 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B48E4EF6D for ; Fri, 22 Apr 2022 02:30:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BD898B82B7F for ; Fri, 22 Apr 2022 09:30:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 6B3F9C385B5; Fri, 22 Apr 2022 09:30:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650619812; bh=uZair5wIdcfRAcFneI5mJ2YtmYXtWA580mHptbZYx9Y=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=sbWaq/+hZxdZOT+Dy9hib8i8WHK0yV9E26AUROF462jxLtUSBS5/+bdQtaFRrCO4e IxTTUWTn4B5tXcqdgQM2qhkcgVORN8O0X62tJN8AQOQBH8at2yiNPC3GRDTUNK41Q4 GEgQ9Hs6RoK7gaq9z+dyRSzulqbjz2Fmife2QiJ0qZNRRFK4Q53orO96slA73ZGzYc WDqbU1XV9w3WZbKEN3O//adSUSPGnil76oPZaAD3o4EhksysTBPwh414cHNmop+Ksi n608uyqbhaH+HeI2PbgjSpBbTwgdIvCsdZr7opFD7vE2X06CyWkedNflC3RSlgtB3z bkQ+PwMfOCNhg== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 53761F0383D; Fri, 22 Apr 2022 09:30:12 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH v2] Bluetooth: use hdev lock for accept_list and reject_list in conn req From: patchwork-bot+bluetooth@kernel.org Message-Id: <165061981233.24106.17851581389197850076.git-patchwork-notify@kernel.org> Date: Fri, 22 Apr 2022 09:30:12 +0000 References: <20220405173751.7269-1-dossche.niels@gmail.com> In-Reply-To: <20220405173751.7269-1-dossche.niels@gmail.com> To: Niels Dossche Cc: linux-bluetooth@vger.kernel.org, marcel@holtmann.org, johan.hedberg@gmail.com, luiz.dentz@gmail.com X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hello: This patch was applied to bluetooth/bluetooth-next.git (master) by Marcel Holtmann : On Tue, 5 Apr 2022 19:37:52 +0200 you wrote: > All accesses (both reads and modifications) to > hdev->{accept,reject}_list are protected by hdev lock, > except the ones in hci_conn_request_evt. This can cause a race > condition in the form of a list corruption. > The solution is to protect these lists in hci_conn_request_evt as well. > > I was unable to find the exact commit that introduced the issue for the > reject list, I was only able to find it for the accept list. > > [...] Here is the summary with links: - [v2] Bluetooth: use hdev lock for accept_list and reject_list in conn req https://git.kernel.org/bluetooth/bluetooth-next/c/1072b8391c7c You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html