Received: by 2002:a05:6602:2086:0:0:0:0 with SMTP id a6csp4547893ioa; Wed, 27 Apr 2022 06:16:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx3pvPwc7MgwKRxuas6H9Wg9r4E/wbq5A7rrDETxlIMS+dMP78Vn0jjMCWMyjFQEwTHNw5B X-Received: by 2002:a05:6808:2388:b0:324:f195:bcb5 with SMTP id bp8-20020a056808238800b00324f195bcb5mr10949629oib.238.1651065403098; Wed, 27 Apr 2022 06:16:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651065403; cv=none; d=google.com; s=arc-20160816; b=wAu8HJ5v8UUqEqfvZEwntna6Jcm1xOjp+7mkDhDDtahKQcZKqzUVCh5dmS/C3Wp7Yr qorlVH/E3WH4WnFADs9S63dsEFgr0s2kaNvohw6+42thZTKsmWqBwKxjDLh0PPjnnZL/ dNVq8GHgf17Ga8lUJ60Pzuv+Ef34pIfi+un4ne+lBACYtgIkH8knmO9bPCh185BFFKPh 1Q3rNMXPS8+uFbQ7p4dyIJfsXTtaADW2kDHc4Ay4OLAMok3UqKjNiYRJGxlkhJoy6ush u4Kw5qUUxR02F8ZS+MrWo6OhM1vv1i0VDqWKtdqnarA96U/e2KLs46dc/fLkwp6TvxdV M+LQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:references:message-id :content-transfer-encoding:cc:date:in-reply-to:from:subject :mime-version; bh=edNv5jWSvT9h1TACvNVnDtaHh5AW+C+BNBO5VtebCnU=; b=SXykt8/CGQ4X9SVeZ9g+2yCOojv7/LSXsk78lh0V2JKQlTbH86XaUD580SoegtZMeZ B7NNM01docUb9miL9pj544KRujySHKKMtmfRm7UjTZIUM/OBpmJ+nae412sg/M3S8i7r IPIl1oGBXA0vUV9dRWLenePQkLJcYErqfPQjezyk0HU4oRl0efVKdyF6ZnNjzplm2WbH 2gm4zEFQsC1Kc62kVUdIrLrTJZXnujthxe3ISHsXFjB/G/zt2+jxA6KgKifDlJ+jf9tB 2Zie5l6wEWCzX38awJlZk9VdWDOHz7JphvMdyvWgoOfrUTiHTwudneg0izrZFvbgWjiJ uXaw== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning linux-bluetooth-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id g5-20020a056870c14500b000e97ecc14b8si994987oad.93.2022.04.27.06.16.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Apr 2022 06:16:43 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-bluetooth-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning linux-bluetooth-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 900EA2BBD6A; Wed, 27 Apr 2022 05:49:25 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234777AbiD0Mwe (ORCPT + 99 others); Wed, 27 Apr 2022 08:52:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234745AbiD0Mwb (ORCPT ); Wed, 27 Apr 2022 08:52:31 -0400 Received: from mail.holtmann.org (coyote.holtmann.net [212.227.132.17]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B95402BFB47; Wed, 27 Apr 2022 05:49:14 -0700 (PDT) Received: from smtpclient.apple (p4ff9fbd8.dip0.t-ipconnect.de [79.249.251.216]) by mail.holtmann.org (Postfix) with ESMTPSA id B5B50CECF1; Wed, 27 Apr 2022 14:49:13 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\)) Subject: Re: [PATCH] Bluetooth: ath3k: Add MODULE_FIRMWARE for patch and config files From: Marcel Holtmann In-Reply-To: <20220427063504.384540-1-juergh@protonmail.com> Date: Wed, 27 Apr 2022 14:49:13 +0200 Cc: Johan Hedberg , Luiz Augusto von Dentz , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, Juerg Haefliger Content-Transfer-Encoding: 7bit Message-Id: <7E038C77-771A-415D-B963-128EB5DD9D48@holtmann.org> References: <20220427063504.384540-1-juergh@protonmail.com> To: Juerg Haefliger X-Mailer: Apple Mail (2.3696.80.82.1.1) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Juerg, > The ath3k driver loads patch and configuration files so add MODULE_FIRMWARE > macros to povide that information via modinfo. > > Signed-off-by: Juerg Haefliger > --- > drivers/bluetooth/ath3k.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/bluetooth/ath3k.c b/drivers/bluetooth/ath3k.c > index 88262d3a9392..56e9a64177ae 100644 > --- a/drivers/bluetooth/ath3k.c > +++ b/drivers/bluetooth/ath3k.c > @@ -538,3 +538,5 @@ MODULE_DESCRIPTION("Atheros AR30xx firmware driver"); > MODULE_VERSION(VERSION); > MODULE_LICENSE("GPL"); > MODULE_FIRMWARE(ATH3K_FIRMWARE); > +MODULE_FIRMWARE("ar3k/AthrBT_0x*.dfu"); > +MODULE_FIRMWARE("ar3k/ramps_0x*_*.dfu"); since when do we allow GLOB pattern matching here? Regards Marcel