Received-SPF: softfail (google.com: domain of transitioning linux-bluetooth-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Wed, 27 Apr 2022 15:46:33 +0000
To:     Marcel Holtmann <marcel@holtmann.org>
From:   Juerg Haefliger <juergh@protonmail.com>
Cc:     Juerg Haefliger <juerg.haefliger@canonical.com>,
        Johan Hedberg <johan.hedberg@gmail.com>,
        Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
        linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org
Reply-To: Juerg Haefliger <juergh@protonmail.com>
Subject: Re: [PATCH] Bluetooth: ath3k: Add MODULE_FIRMWARE for patch and config files
Message-ID: <_GyJWTeZu6emLzFDC3fwvOlBC6CqO2OT6cl_P8DnD9DHXND2rEgLQu6naToxpYZzorpJVZXkVJ1JB3ASqcRSncyBCcov8084Q8YABhoDCL4=@protonmail.com>
In-Reply-To: <7E038C77-771A-415D-B963-128EB5DD9D48@holtmann.org>
References: <20220427063504.384540-1-juergh@protonmail.com> <7E038C77-771A-415D-B963-128EB5DD9D48@holtmann.org>
Feedback-ID: 10260306:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

------- Original Message -------
On Wednesday, April 27th, 2022 at 14:49, Marcel Holtmann <marcel@holtmann.o=
rg> wrote:

>
>
> Hi Juerg,
>
> > The ath3k driver loads patch and configuration files so add MODULE_FIRM=
WARE
> > macros to povide that information via modinfo.
> >
> > Signed-off-by: Juerg Haefliger juergh@protonmail.com
> > ---
> > drivers/bluetooth/ath3k.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/bluetooth/ath3k.c b/drivers/bluetooth/ath3k.c
> > index 88262d3a9392..56e9a64177ae 100644
> > --- a/drivers/bluetooth/ath3k.c
> > +++ b/drivers/bluetooth/ath3k.c
> > @@ -538,3 +538,5 @@ MODULE_DESCRIPTION("Atheros AR30xx firmware driver"=
);
> > MODULE_VERSION(VERSION);
> > MODULE_LICENSE("GPL");
> > MODULE_FIRMWARE(ATH3K_FIRMWARE);
> > +MODULE_FIRMWARE("ar3k/AthrBT_0x*.dfu");
> > +MODULE_FIRMWARE("ar3k/ramps_0x*_*.dfu");
>
>
> since when do we allow GLOB pattern matching here?

Not sure when that was first introduced but:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?=
id=3D75729e110e680687668fd5b4bdd7b25c92e9c00d

...Juerg


> Regards
>
> Marcel