Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b058f6ec77bef1570214be4711b16012ea030d2c.camel@linux.intel.com>
Subject: Re: [PATCH bluetooth-next 2/3] net: 6lowpan: use array for find nhc
 id
From:   Jukka Rissanen <jukka.rissanen@linux.intel.com>
To:     Alexander Aring <aahringo@redhat.com>
Cc:     linux-bluetooth@vger.kernel.org, linux-wpan@vger.kernel.org,
        stefan@datenfreihafen.org, torvalds@linuxfoundation.org
Date:   Tue, 03 May 2022 10:32:16 +0300
In-Reply-To: <20220428030534.3220410-3-aahringo@redhat.com>
References: <20220428030534.3220410-1-aahringo@redhat.com>
         <20220428030534.3220410-3-aahringo@redhat.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Wed, 2022-04-27 at 23:05 -0400, Alexander Aring wrote:
> This patch will remove the complete overengineered and overthinking
> rb data
> structure for looking up the nhc by nhcid. Instead we using the
> existing
> nhc next header array and iterate over it. It works now for 1 byte
> values
> only. However there are only 1 byte nhc id values currently
> supported and IANA also does not specify large than 1 byte values
> yet.
> If there are 2 byte values for nhc ids specified we can revisit this
> data structure and add support for it.
> 
> Signed-off-by: Alexander Aring <aahringo@redhat.com>
> ---
>  net/6lowpan/nhc.c               | 91 +++++--------------------------
> --
>  net/6lowpan/nhc.h               | 28 ++++------
>  net/6lowpan/nhc_dest.c          |  9 +---
>  net/6lowpan/nhc_fragment.c      |  9 +---
>  net/6lowpan/nhc_ghc_ext_dest.c  |  9 +---
>  net/6lowpan/nhc_ghc_ext_frag.c  | 11 +---
>  net/6lowpan/nhc_ghc_ext_hop.c   |  9 +---
>  net/6lowpan/nhc_ghc_ext_route.c |  9 +---
>  net/6lowpan/nhc_ghc_icmpv6.c    |  9 +---
>  net/6lowpan/nhc_ghc_udp.c       |  9 +---
>  net/6lowpan/nhc_hop.c           |  9 +---
>  net/6lowpan/nhc_ipv6.c          | 11 +---
>  net/6lowpan/nhc_mobility.c      |  9 +---
>  net/6lowpan/nhc_routing.c       |  9 +---
>  net/6lowpan/nhc_udp.c           |  9 +---
>  15 files changed, 37 insertions(+), 203 deletions(-)
> 
> diff --git a/net/6lowpan/nhc.c b/net/6lowpan/nhc.c
> index d6bbbd4ab38b..019f121b2449 100644
> --- a/net/6lowpan/nhc.c
> +++ b/net/6lowpan/nhc.c
> @@ -12,77 +12,26 @@
>  

Acked-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>


Cheers,
Jukka