Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 4 May 2022 15:31:15 -0500
From:   Rob Herring <robh@kernel.org>
To:     Balakrishna Godavarthi <quic_bgodavar@quicinc.com>
Cc:     agross@kernel.org, bjorn.andersson@linaro.org,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, marcel@holtmann.org,
        johan.hedberg@gmail.com, mka@chromium.org,
        linux-bluetooth@vger.kernel.org, quic_hemantg@quicinc.com,
        quic_saluvala@quicinc.com, quic_rjliao@quicinc.com,
        mcchou@chromium.org
Subject: Re: [PATCH v1 1/3] dt-bindings: net: bluetooth: Add wlan-gpio entry
 for wcn6750
Message-ID: <YnLik/JKsHs6yfwc@robh.at.kernel.org>
References: <1651228073-1999-1-git-send-email-quic_bgodavar@quicinc.com>
 <1651228073-1999-2-git-send-email-quic_bgodavar@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1651228073-1999-2-git-send-email-quic_bgodavar@quicinc.com>
Precedence: bulk

On Fri, Apr 29, 2022 at 03:57:51PM +0530, Balakrishna Godavarthi wrote:
> This patch adds a wlan-gpio entry and its reference usage for

wlan-gpios

> BT SoC wcn6750.
> 
> Signed-off-by: Sai Teja Aluvala <quic_saluvala@quicinc.com>
> Signed-off-by: Balakrishna Godavarthi <quic_bgodavar@quicinc.com>
> ---
>  Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml
> index f93c6e7..624f957 100644
> --- a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml
> +++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml
> @@ -24,6 +24,10 @@ properties:
>        - qcom,qca6390-bt
>        - qcom,wcn6750-bt
>  
> +  wlan-gpios:
> +    maxItems: 1
> +    description: gpio specifier used to wlan chip

How does one 'wlan' a chip?

> +
>    enable-gpios:
>      maxItems: 1
>      description: gpio specifier used to enable chip
> @@ -123,6 +127,7 @@ allOf:
>                - qcom,wcn6750-bt
>      then:
>        required:
> +        - wlan-gpios
>          - enable-gpios
>          - swctrl-gpios
>          - vddio-supply
> @@ -166,6 +171,7 @@ examples:
>              compatible = "qcom,wcn6750-bt";
>              pinctrl-names = "default";
>              pinctrl-0 = <&bt_en_default>;
> +            wlan-gpios = <&tlmm 84 GPIO_ACTIVE_HIGH>;
>              enable-gpios = <&tlmm 85 GPIO_ACTIVE_HIGH>;
>              swctrl-gpios = <&tlmm 86 GPIO_ACTIVE_HIGH>;
>              vddio-supply = <&vreg_l19b_1p8>;
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
> 
>