Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220504210948.2968827-1-jiangzp@google.com> <CABBYNZL3cfwK7THDwUbg5AKx4GFfrZij2FhHfSPCgmRM1B7L+g@mail.gmail.com>
 <CAB4PzUrFr+ZXMNpToM+c4pfNJoAdVyfV2XoCGKtUGg_3MMCtag@mail.gmail.com>
In-Reply-To: <CAB4PzUrFr+ZXMNpToM+c4pfNJoAdVyfV2XoCGKtUGg_3MMCtag@mail.gmail.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Wed, 4 May 2022 14:57:49 -0700
Message-ID: <CABBYNZJ8wEWqjNr1t17HN4WHQ9xy_YiCbq0MDo26boSv5f1k0A@mail.gmail.com>
Subject: Re: [Bluez PATCH v3 0/3] Adding bonded flag to D-Bus property
To:     Zhengping Jiang <jiangzp@google.com>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
        ChromeOS Bluetooth Upstreaming 
        <chromeos-bluetooth-upstreaming@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Zhengping,

On Wed, May 4, 2022 at 2:54 PM Zhengping Jiang <jiangzp@google.com> wrote:
>
> Hi Luiz,
>
> Sorry for the error. It should have been fixed in patch 2. I think I upda=
ted the wrong version.

Don't worry, I'm fixing it myself.

> Thanks,
> Zhengping
>
> On Wed, May 4, 2022 at 2:49 PM Luiz Augusto von Dentz <luiz.dentz@gmail.c=
om> wrote:
>>
>> Hi Zhengping,
>>
>> On Wed, May 4, 2022 at 2:09 PM Zhengping Jiang <jiangzp@google.com> wrot=
e:
>> >
>> > Currently BlueZ client can't know easily whether a device is bonded or
>> > not. This is causing issues for a number of applications. For example,
>> > in the Nearby Share case, the peer device is paired, but not bonded.
>> > This series will add the "Bonded" property in org.bluez.Device1 D-Bus
>> > interface. Changes are also made in bluetoothctl to show the status of
>> > the bonded flag as well as a list of bonded devices.
>> >
>> > Changes in v3:
>> > - Move documentation update to a separate patch
>> > - Add description to bonded and paired
>> > - Add an optional argument to the devices command to filter device lis=
t
>> > - Remove paired-devices command
>> >
>> > Changes in v2:
>> > - Move one variable declaration to the top following C90 standard
>> >
>> > Changes in v1:
>> > - Add "Bonded" to D-Bus interface
>> > - Send property changed signal if the bonded flag is changed
>> > - Show the status of the "Bonded" flag in bluetoothctl
>> > - Add option to show list of bonded devices
>> >
>> > Zhengping Jiang (3):
>> >   device: Add "Bonded" flag to dbus property
>> >   doc: add "Bonded" flag to dbus property
>> >   client: Add filter to devices and show Bonded in info
>> >
>> >  client/main.c      | 72 ++++++++++++++++++++++++++++++---------------=
-
>> >  doc/device-api.txt | 12 +++++++-
>> >  src/device.c       | 38 ++++++++++++++++++++----
>> >  3 files changed, 91 insertions(+), 31 deletions(-)
>> >
>> > --
>> > 2.36.0.464.gb9c8b46e94-goog
>>
>> src/device.c: In function =E2=80=98device_set_bonded=E2=80=99:
>> src/device.c:6141:9: error: ISO C90 forbids mixed declarations and
>> code [-Werror=3Ddeclaration-after-statement]
>>  6141 |         struct bearer_state *state =3D get_state(device, bdaddr_=
type);
>>       |
>>
>>
>> --
>> Luiz Augusto von Dentz


--=20
Luiz Augusto von Dentz