Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Wed, 8 Jun 2022 16:46:13 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Marcel Holtmann <marcel@holtmann.org>,
        Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
Cc:     Johan Hedberg <johan.hedberg@gmail.com>,
        Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
        Paolo Abeni <pabeni@redhat.com>,
        linux-bluetooth@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH] Bluetooth: fix an error code in hci_register_dev()
Message-ID: <YqCoJXuRV8MIDS2M@kili>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jM8CuYEArOpsMqaUGmRslF8+1yJl+QIMRXxUouaOVxYd2KruLLRI6VJAuovI?=
 =?us-ascii?Q?7zwM4pKJFkAEe+kwZtMRDxMS3+ZlxxWk1tw/ayOioIALkO54OjPX2sfNxJW0?=
 =?us-ascii?Q?V/BsVVcGIyBRl53ZGjLUSDUKbBpckcGVCZrCVAwuRWAon9MyjC27OuJodCIB?=
 =?us-ascii?Q?n4IYdnFmN9EocdS5b68ESCXRF98HElyS7wZ8ZFSUT4bp3us/q+Td3tlSUInB?=
 =?us-ascii?Q?DBj6aIRYJqDKakg3ElgGbfcvkBGsqVvofn4FU08EwUUJcJoZ2+zIskyQwc0L?=
 =?us-ascii?Q?Ivrif1fDqI1BVWHI08HDu+73mTqgvMebZZ22P5BFHDru4xMX112zD2+a0DLQ?=
 =?us-ascii?Q?bkniCv+uGQxkgmx/HXbTIAc+RYizt3dxdF5XxCOJCrlRUmnjEb5EvV0Xrynu?=
 =?us-ascii?Q?C8wi8BAn12t8qnCmOprFK5DpmjB7BLY2dpT4jo702A+TDhIXAWPwpYIkBzxM?=
 =?us-ascii?Q?QYCrxG8ZHbRUlPx+OYFChi+5n9tWRYWglt2J99rSwSp/5h2KenOiAt9PgvF2?=
 =?us-ascii?Q?Nfe76wSKIWOqyTuI/O9LGzfQvXUlw/1agqsPwUNpF2HSMF+tEP8nUumJV1rm?=
 =?us-ascii?Q?WkNwaTHaa7x+RCf+pMctcgxUO+/l5epZeCi/p7HJqoL7JvfxHdq2Q1mI7O1J?=
 =?us-ascii?Q?tUMBcJHkT+FqPqqkPJWY+2vbdGvGm2mG5KQCUwzspuhfF44HsrhgwJvtxx3A?=
 =?us-ascii?Q?7dnd7BAB5uu/8OCehXjZjQs1BwtwFwnIiHkNfBNj8zItsaOUusweI7nRvW8q?=
 =?us-ascii?Q?aDWtNDRRfB5p27WHTy1CP9i59fr/SdRIMychmWYsLufV3rVMuIzlpKjZnOe1?=
 =?us-ascii?Q?MBr66db9909GHyzTpem5AY3tXEPOvbM+mZVnHpYKFlqlWhXOwa1uQNf4t9+c?=
 =?us-ascii?Q?H78iJCIySMEmgBNsx96bC4VtQF+Z/6j13thYqdqslob+grTWRREe8SBCPimB?=
 =?us-ascii?Q?SqnRMh0aq1wn/rwot155+SlWqPSmU8uAvZHNxClsa/s3xK/YYE6Hn49ZpOXH?=
 =?us-ascii?Q?+yphuAXJpiHFhy0/5oxrQmvyVBGrzgllwLIsiktajWLINIs3kcr83360mzDT?=
 =?us-ascii?Q?/CW9WWV8dB2ZGidFWIvf1GOUXqkeQqdx7nz0zoiHM//dHzcaNSulnAM9BsFT?=
 =?us-ascii?Q?I3HaiX1j2sp082L453b3dBSqCKkhtKU508pMOkW/apCBibKItFPVUeawCAdU?=
 =?us-ascii?Q?zXCN95Hl93DZ0CwgzNSsAUk4Olk87fLAQI9dGrOJPQ4NIcY5CtXXMjBMqBr/?=
 =?us-ascii?Q?icVb/OWVWwRBNtv5p7AWR+1TXWJPHEbbWUCu2QIXnvNGHv2mtLdyIQ8B7XWG?=
 =?us-ascii?Q?gvUZv5crXwbXzJs89R+y/aXNWsAsRNNZGEu6XUGHElA71jh47FisZwG/kcZ8?=
 =?us-ascii?Q?LFMBjE6KofoDQLOElk2SxA0RkCFlAiHk4G61/KF1j+ciMSBgp8FLp8UZ9RdR?=
 =?us-ascii?Q?WUVN78Y4qyIVvs9/v8EeZOJlHRYn/zB0sVDp2Ft8ohKYQ8806+pdrXJnEGmH?=
 =?us-ascii?Q?skq8n4YOtEtst9CU+vzo/RhdGb9QxSFDV13Mknfg5y+zJtf9bBpLjij+vyGl?=
 =?us-ascii?Q?zUyzwZgfoYOjdZeQknKaZPsiXLGl0iwfDaHjQPhV2X+atM4CBwv2IRJfIpjv?=
 =?us-ascii?Q?PNgReE5fFOPn3UbUE6LfcsucOddgsQDgnIbzDjgpwS2x94hKtK48HuA/xr45?=
 =?us-ascii?Q?X6Dhx6CODc58aykJjR4y8mnRDHdf1K8CC7wl0AsjyR/UDBuafERnNvP6Qfwm?=
 =?us-ascii?Q?ArS7RZo/fYLQvJOEcgLNaZ/Iaq1GlEE=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 24a43592-a444-4ce3-a1bc-08da495548a7
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2022 13:46:26.8370
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IVozIfJa5gOCn/WgJgRhoQhs2ZSNOb56Yc6XoIWHYTpNpoErrcznXQv6tAx4f2EPRHys8GZKEpkutuI7oWSz+XVCf63zJMMx+CM8rWNY3gs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR10MB1426
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.874
 definitions=2022-06-08_04:2022-06-07,2022-06-08 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 spamscore=0
 adultscore=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2204290000 definitions=main-2206080059
X-Proofpoint-ORIG-GUID: FhQgnYOh4KSRJc2yl95ku8W8rOMC4Iez
X-Proofpoint-GUID: FhQgnYOh4KSRJc2yl95ku8W8rOMC4Iez
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

Preserve the error code from hci_register_suspend_notifier().  Don't
return success.

Fixes: d6bb2a91f95b ("Bluetooth: Unregister suspend with userchannel")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 net/bluetooth/hci_core.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
index a4b4b3b927f2..dbddf891a4a9 100644
--- a/net/bluetooth/hci_core.c
+++ b/net/bluetooth/hci_core.c
@@ -2646,7 +2646,8 @@ int hci_register_dev(struct hci_dev *hdev)
 	hci_sock_dev_event(hdev, HCI_DEV_REG);
 	hci_dev_hold(hdev);
 
-	if (hci_register_suspend_notifier(hdev))
+	error = hci_register_suspend_notifier(hdev);
+	if (error)
 		goto err_wqueue;
 
 	queue_work(hdev->req_workqueue, &hdev->power_on);
-- 
2.35.1