Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220610072850.16593-1-frederic.danis@collabora.com> <20220610072850.16593-3-frederic.danis@collabora.com>
In-Reply-To: <20220610072850.16593-3-frederic.danis@collabora.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Fri, 10 Jun 2022 08:48:51 -0700
Message-ID: <CABBYNZLgh+7JfWgX59+=t5_DM45EJyPTTU=8+whxZk8KiJXkug@mail.gmail.com>
Subject: Re: [PATCH BlueZ v2 2/3] test-runner: Add audio card support
To:     =?UTF-8?B?RnLDqWTDqXJpYyBEYW5pcw==?= <frederic.danis@collabora.com>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Fr=C3=A9d=C3=A9ric,

On Fri, Jun 10, 2022 at 12:30 AM Fr=C3=A9d=C3=A9ric Danis
<frederic.danis@collabora.com> wrote:
>
> With this commit audio daemons can detect an audio card with output and
> input, allowing to test interaction between BlueZ and the audio daemon.
> ---
>  doc/test-runner.txt |  5 +++++
>  tools/test-runner.c | 23 ++++++++++++++++++++++-
>  2 files changed, 27 insertions(+), 1 deletion(-)
>
> diff --git a/doc/test-runner.txt b/doc/test-runner.txt
> index 683c622a2..019c23188 100644
> --- a/doc/test-runner.txt
> +++ b/doc/test-runner.txt
> @@ -54,6 +54,11 @@ For Bluetooth functionality:
>
>         CONFIG_UHID=3Dy
>
> +For Audio functionality:
> +       CONFIG_SYSVIPC=3Dy
> +       CONFIG_SOUND=3Dy
> +       CONFIG_SND=3Dy
> +       CONFIG_SND_INTEL8X0=3Dy

Lets have this as a separate patch.

>  These options should be installed as .config in the kernel source direct=
ory
>  followed by this command.
> diff --git a/tools/test-runner.c b/tools/test-runner.c
> index 9fc8e7b33..bbbca5b5d 100644
> --- a/tools/test-runner.c
> +++ b/tools/test-runner.c
> @@ -54,6 +54,7 @@ static bool start_monitor =3D false;
>  static int num_devs =3D 0;
>  static const char *qemu_binary =3D NULL;
>  static const char *kernel_image =3D NULL;
> +static bool audio_support;
>
>  static const char *qemu_table[] =3D {
>         "qemu-system-x86_64",
> @@ -261,6 +262,7 @@ static void start_qemu(void)
>                                 run_auto, testargs);
>
>         argv =3D alloca(sizeof(qemu_argv) +
> +                               (audio_support ? 4 : 0) +
>                                 (sizeof(char *) * (4 + (num_devs * 4))));
>         memcpy(argv, qemu_argv, sizeof(qemu_argv));
>
> @@ -268,6 +270,20 @@ static void start_qemu(void)
>
>         argv[0] =3D (char *) qemu_binary;
>
> +       if (audio_support) {
> +               char *xdg_runtime_dir, *audiodev;
> +
> +               xdg_runtime_dir =3D getenv("XDG_RUNTIME_DIR");
> +               audiodev =3D alloca(40 + strlen(xdg_runtime_dir));
> +               sprintf(audiodev, "id=3Daudio,driver=3Dpa,server=3D%s/pul=
se/native",
> +                               xdg_runtime_dir);
> +
> +               argv[pos++] =3D "-audiodev";
> +               argv[pos++] =3D audiodev;
> +               argv[pos++] =3D "-device";
> +               argv[pos++] =3D "AC97,audiodev=3Daudio";
> +       }
> +
>         argv[pos++] =3D "-kernel";
>         argv[pos++] =3D (char *) kernel_image;
>         argv[pos++] =3D "-append";
> @@ -990,6 +1006,7 @@ static void usage(void)
>                 "\t-u, --unix [path]      Provide serial device\n"
>                 "\t-q, --qemu <path>      QEMU binary\n"
>                 "\t-k, --kernel <image>   Kernel image (bzImage)\n"
> +               "\t-A, --audio            Add audio support\n"
>                 "\t-h, --help             Show help options\n");
>  }
>
> @@ -1004,6 +1021,7 @@ static const struct option main_options[] =3D {
>         { "monitor", no_argument,       NULL, 'm' },
>         { "qemu",    required_argument, NULL, 'q' },
>         { "kernel",  required_argument, NULL, 'k' },
> +       { "audio",   no_argument,       NULL, 'A' },
>         { "version", no_argument,       NULL, 'v' },
>         { "help",    no_argument,       NULL, 'h' },
>         { }
> @@ -1023,7 +1041,7 @@ int main(int argc, char *argv[])
>         for (;;) {
>                 int opt;
>
> -               opt =3D getopt_long(argc, argv, "aubdslmq:k:vh", main_opt=
ions,
> +               opt =3D getopt_long(argc, argv, "aubdslmq:k:Avh", main_op=
tions,
>                                                                 NULL);
>                 if (opt < 0)
>                         break;
> @@ -1057,6 +1075,9 @@ int main(int argc, char *argv[])
>                 case 'k':
>                         kernel_image =3D optarg;
>                         break;
> +               case 'A':
> +                       audio_support =3D true;
> +                       break;
>                 case 'v':
>                         printf("%s\n", VERSION);
>                         return EXIT_SUCCESS;
> --
> 2.25.1
>


--=20
Luiz Augusto von Dentz