Received: by 2002:a5d:925a:0:0:0:0:0 with SMTP id e26csp1611594iol; Fri, 10 Jun 2022 10:54:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzGiCXpq9MuBUaMJsTpLiWjqE9LZaed3XFg+QfBLzdel45kO7bYR3LcHNf5DA1kSr6rLBCt X-Received: by 2002:a63:54f:0:b0:3fd:9bbe:a2c3 with SMTP id 76-20020a63054f000000b003fd9bbea2c3mr26625362pgf.5.1654883694908; Fri, 10 Jun 2022 10:54:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654883694; cv=none; d=google.com; s=arc-20160816; b=y5ttiPypxZ3qbr7CBAU1UqICqWZXYiNnNbvRC/fI/hIakwfswOX9h3p7J+j9d+Snz6 U/Ng2nF5SgEXKdWpl2R8aU//hUE71tuaZqId9g4SXppYvPyo3OEj6bRxliM6WIHu3XiX xZ6IztPfC+wl4MWsRS5Hw2E+ABo0n1bZMwUyloRK3qXFhP6KtjuHd8B0DYomoXIH/692 9+4CW2otFFqGqDLoq1IMWMcUsJZYxfIgOZNgZBHgKEiXcpgV1c6vpC8GjNAxbFVchrff nZ9Kq4W9jXNmjklk8ssdDr9FztaSMhNMI2MhFFX6LqCfme7ajJxlJi5HlkSWgrPHLpat h04A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=EP2CN5s/HOY++c1dpVKxmHeYgyVSXN/8MbQfIfErye8=; b=Q72ECjpOQbD054vOjMM9Zn0T1PveTqilbe/69Yala0Avv5LgowqDy+2oOfSnPNqEUi cofwQCNoizIuWBvpJ9V5RzQV925pEO18Sbbj66441MA9QsQqliY1pdad8JjxqgutBjb7 iARknk/8Jjt4+1m/w2DeUQQlSiCXLz+/cj5usIjr5K6mmEoXS8D19MOKkvEueZzBe+D4 i0M9yJ+A4qfQYpC5+LhKEl85U7lCkthJ383+TIRBIKcK5PHh3qpb6g7VnIaY1YpfXZXj nwruhVn9UyxZoOCzvTr2pgcx3S9aiGT3uC52tfjj+j99zU4sDb6P/7DeFFHH86LzcMs9 kIMw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=hFNyhbvX; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h9-20020a170902f70900b00161558a437fsi41851plo.160.2022.06.10.10.54.25; Fri, 10 Jun 2022 10:54:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=hFNyhbvX; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347141AbiFJRwT (ORCPT + 99 others); Fri, 10 Jun 2022 13:52:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244289AbiFJRwT (ORCPT ); Fri, 10 Jun 2022 13:52:19 -0400 Received: from mail-yb1-xb30.google.com (mail-yb1-xb30.google.com [IPv6:2607:f8b0:4864:20::b30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D31639E499 for ; Fri, 10 Jun 2022 10:52:18 -0700 (PDT) Received: by mail-yb1-xb30.google.com with SMTP id t1so2078151ybd.2 for ; Fri, 10 Jun 2022 10:52:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=EP2CN5s/HOY++c1dpVKxmHeYgyVSXN/8MbQfIfErye8=; b=hFNyhbvXEzy6gLrU3R6dS6JJpwgfscNMPFdjNjlKlBKBPwaSzP2hSpElzqUnxQfE4l YeKzmd9x5oP2cI97HEyotquV091oF3dKMhja/aRwjNtCFFBokzmGqGojoO2LMJr83JnW 4G3i085mTY2P3Q3sCJfpeQ78JFsTyjJc3iBvWccTfGu9aLht9iI8Ba1mC8ANXUQ11KIu LelwAnLHxflAqu4BOoS1IdFiNZGmlsuIUGK0rpVLDNWsM20xmEW/XOH66hZTJlsut4og vTpC8ypqi9RYI2W5GVr+NI7Yl22eh4cg6D9Ojlg6FnrRzCKlQ2OOz/Fa4d5Y80APKioM C6sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=EP2CN5s/HOY++c1dpVKxmHeYgyVSXN/8MbQfIfErye8=; b=G/cqyIZjImCn2uInUBPDOyAqy4eYxVwIE/NU4m8cEpFJAaAyqXRKZOgtDgJDnRzD7n 8l7jSA1pshnJMZFiznpoBjruA3FR2To+2PWWp3FwZ5qRfPY75FwpSZnOGOjnEC1zYDur WQfutpdBxFBOVw0JPZdVc0+SDRj1Id/mMVdwcrP9BwLOymDbwt+iXSAMxLYk4bq+5jlY ckeXWjEut7Hv8JP5hMfMdxp2EbHKibbmX20ain9rCs0iVzAXuXta/HhP50dSpGqxG133 iWWn1gRN7Ph5/bFk/WRSHOY3xlKU9kQT5877wOnpF0aSzDTqXnWAcradE27kO26YDBY4 pDYg== X-Gm-Message-State: AOAM531H9lyGUVxuU3tK2QgDeWISMyLm8+uDWmOj+szN/9BeolTRAO3z 0zUkEkOt5b6KP6kSGZNfxMZpouM5PEkn035VYl3+XsU8 X-Received: by 2002:a25:780b:0:b0:664:3e22:3368 with SMTP id t11-20020a25780b000000b006643e223368mr8199689ybc.625.1654883537524; Fri, 10 Jun 2022 10:52:17 -0700 (PDT) MIME-Version: 1.0 References: <20220603223225.20296-1-puffy.taco@gmail.com> In-Reply-To: <20220603223225.20296-1-puffy.taco@gmail.com> From: Mike Brudevold Date: Fri, 10 Jun 2022 12:52:06 -0500 Message-ID: Subject: Re: [PATCH 0/3] LE OOB pairing support To: linux-bluetooth Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org More testing below. On Fri, Jun 3, 2022 at 5:32 PM Michael Brudevold wrote: > > From: Michael Brudevold > > This patch series implements userspace support for LE OOB pairing. It was > tested against an nRF52 dev kit with Nordic's NFC pairing example. Support is > only for reading a tag; generating and sending back OOB information was not > implemented. Further testing indicates that the OOB pairing data was not being used (beyond BD addr). I tried corrupting the relevant fields and it still successfully paired. The bluetooth capture in Wireshark shows an SMP Pairing Request going out with the OOB data flags set to zero (OOB auth not present). This is a 5.13 kernel from Ubuntu 20.04, so I'll check that it isn't a kernel version issue, but a coworker tested on an Ubuntu 22.04 instance and had a similar high level experience. I'm still digging into where/how the OOB flag gets set for this request. > > Overall, LE EIR data is not dissimilar to BREDR, but the OOB blob starts off > slightly differently necessitating a different code path before reaching the > EIR parser. > > Michael Brudevold (3): > eir: parse data types for LE OOB pairing > Accept LE formatted EIR data with neard plugin > neard: Update D-Bus path and interface > > plugins/neard.c | 64 +++++++++++++++++++++++++++++++++++++++++++------ > src/adapter.c | 3 ++- > src/adapter.h | 2 +- > src/eir.c | 21 ++++++++++++++++ > src/eir.h | 4 ++++ > 5 files changed, 85 insertions(+), 9 deletions(-) > > -- > 2.25.1 >