Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <698fa316-4328-765b-80f4-b5cee03bcdde@molgen.mpg.de>
Date:   Tue, 14 Jun 2022 15:21:45 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH] obexd: Fix transfer has been free in
 transfer_abort_response
Content-Language: en-US
To:     wangyouwan@uniontech.com
References: <20220614131549.22054-1-wangyouwan@uniontech.com>
Cc:     linux-bluetooth@vger.kernel.org
From:   Paul Menzel <pmenzel@molgen.mpg.de>
In-Reply-To: <20220614131549.22054-1-wangyouwan@uniontech.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Dear Wang,


Thank you for your patch.

Am 14.06.22 um 15:15 schrieb wangyouwan:

Can you please configure your full name in git?

     git config --global user.name "Wang …"

> Breakpoint 7, transfer_new (obex=0x5555555f5b50, opcode=2 '\002',
> complete_func=0x555555590c40 <xfer_complete>, user_data=0x5555555f7000)
> at gobex/gobex-transfer.c:254
> 254     gobex/gobex-transfer.c:
> (gdb) c
> Continuing.

[…]

In addition to the GDB traces, can you please add a sentence, what is 
going on, and how to reproduce (test setup) that the transfer 
(`find_transfer(id)`) is NULL?

[…]
> ---
>   gobex/gobex-transfer.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/gobex/gobex-transfer.c b/gobex/gobex-transfer.c
> index c94d018b2..48b1f6962 100644
> --- a/gobex/gobex-transfer.c
> +++ b/gobex/gobex-transfer.c
> @@ -92,7 +92,9 @@ static void transfer_complete(struct transfer *transfer, GError *err)
>   		g_obex_drop_tx_queue(transfer->obex);
>   	}
>   
> -	transfer->complete_func(transfer->obex, err, transfer->user_data);
> +	if (find_transfer(id) != NULL)
> +		transfer->complete_func(transfer->obex, err, transfer->user_data);
> +
>   	/* Check if the complete_func removed the transfer */
>   	if (find_transfer(id) == NULL)
>   		return;


Kind regards,

Paul