Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 16 Jun 2022 10:54:31 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Linus Walleij <linus.walleij@linaro.org>
Cc:     Marcel Holtmann <marcel@holtmann.org>,
        Johan Hedberg <johan.hedberg@gmail.com>,
        Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
        linux-bluetooth@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: btbcm: Use strreplace() in
 btbcm_get_board_name()
Message-ID: <20220616075431.GA16517@kadam>
References: <YqmXmsTX7dD+5HjN@kili>
 <CACRpkdbStsAF2Jngohh7Lsg6xs0Vsc-v_SR3WC3ndbZEhx9tEg@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CACRpkdbStsAF2Jngohh7Lsg6xs0Vsc-v_SR3WC3ndbZEhx9tEg@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?iQXqCTgZEEKWb3YFQc0n6O+bKw8OSw1BCZ2Q7O34qj3kHamcXECy7idNOLn5?=
 =?us-ascii?Q?Qsjj+XsZw+tbuhyhTGm3uwgBA2KJvFT1AjEAmSz+IjO4kD//NXiLfFXrGWdi?=
 =?us-ascii?Q?jP4tCWpzHxs+jDjUB50tgqLoDmXFHAwuIdxWjxf7kCoMTGqDAhWMxmuCyOeZ?=
 =?us-ascii?Q?dSWHz3lgjUiyRLdIJ4mQnyLrcoxrz8vgWH+f5BhwbPV5EJIFvZiJ63ud9hAM?=
 =?us-ascii?Q?h57LKbYdYSD6HNEp6h0InNebM3krLCV8xS3Ou72wTbAl+xV4QcjJZQtdVi7t?=
 =?us-ascii?Q?RGy7r1K4dr+kxlKcpsGi3uxqYA/BNRz+x+GwbY3Ro6I1IJlK/jyIanow8LCM?=
 =?us-ascii?Q?hg2L7lyXN+rPRpnM0kKPDxChWoA8hd/PYB/XI8VVObBHjHHT7qPFAwbzQ0lK?=
 =?us-ascii?Q?6NsTntZrVBIQhx0QL+6h490Xiof8ZTSZg8Qp/HSorOgWVTHSC+Cnzeiahk7e?=
 =?us-ascii?Q?f97XdzR6XgMHL/0VzFN9xAOsO4buKBG6hlbi4TBeCb1ksD+PGxoWpDHAcY/l?=
 =?us-ascii?Q?HulAR991OLI1zPhZicsVT2O0Y4QRff9sEbTahxfq/7AGFoHXAwoB4hxHMYoo?=
 =?us-ascii?Q?UxOt5TY4qIywZPVgujAALpM2p0uLsfCRlDawjn1cmUvnALoqpVGdNeY2DPUC?=
 =?us-ascii?Q?UQp6vhJqUwu+aRy5Xs06HqMF9J88+Tf9AB1rJt/O2J/kb4n7FRoI0q7gF0JQ?=
 =?us-ascii?Q?3t7qK6zwkMdmmuWlMqGjibSPibskiAO8wfxtIIPVLnSmCBAGkJPuvxIiyEIG?=
 =?us-ascii?Q?A+yaX/+h4qugO437FVtNibx/OVVTlPgCTG+BnxZKj9Kz+BZLAZNstg59FmgA?=
 =?us-ascii?Q?xf+9nGTuErlWL4Cxg8gRj+JuL45V7UVknLiaqXfJMd9hQl8MNHAey1xs4vt4?=
 =?us-ascii?Q?Dcm1+wYIlV23QrYmBsJt7vGFO0hbMJOJzytxLMEdRZw69tUUMW7SHkysl3NJ?=
 =?us-ascii?Q?1QnS9AHmdTbFJ2zzzXnKwmUgrMFzjYTHtLgp2b5Yp37wscQVsqitPRmRsC38?=
 =?us-ascii?Q?tKRxP8nHrPanIPibLUW7FbCZWYDHMV9//oRqdzcxhcowKpK+fE9lHOOPU6o1?=
 =?us-ascii?Q?p75So4Fk3tHZRm9UoW/cYVQ6SayRUExYFr7LmCiatZw6lr6lDiE0hqvTtb4c?=
 =?us-ascii?Q?Iqo33Vc14icOhvkrN56/ofiWZGyvCUruBB0UlBH4PFDTnvIF3rp/16bUTAfE?=
 =?us-ascii?Q?Q0iWUeAWokvtsM+0SefiWbGvjPKz04tA1jgGei+6S36YR+h+W6xJ2WkhpglW?=
 =?us-ascii?Q?M654mWz+CS2ZXkIJ3PS+YpAMn8C2jvReJR87ZfJgmEkXYG+FhoiWi1PeLjAd?=
 =?us-ascii?Q?Q0QLeX4xqB9z1LZEl4S2y14iZKaaTWCiUakFTfWT5z/BgaF0/0LTO6GgODyH?=
 =?us-ascii?Q?OEjEVAZgN58dw2MDkTlN7BB7NbFQ78cFuGPZLe0xuUaI2IPOeXO+40Wanpmg?=
 =?us-ascii?Q?3eLEiPOD6Di2ri8laEz2MjohXlZ/0SUu5rMHbaqL3rxHfA9zelwms9WJY5lT?=
 =?us-ascii?Q?tuWMv8X/jS2S8ExQXZhDH4WZjLGStXyH6jPxxTvpj5W0m1Xg5ptaCD4QMQ0/?=
 =?us-ascii?Q?VTVB9K3QIwfQFZGPV7Q4AZ384bfx3MC38b9Var+GypLv57KX6CoJBGZgM090?=
 =?us-ascii?Q?r71uxHgCj9l6Km/xTnSxDPQqe3hxFzwo3Gkhw5f7zfiyv+XU4JVickLPmU5h?=
 =?us-ascii?Q?o3Dy7IEskmkuVXJPYI0vEVDIX3Oi5Kowf+7pw5RZX6uiGVsw8A79275pYBlg?=
 =?us-ascii?Q?IVgTFZDSlR9G7HEvh7JVWIimaoTokls=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d8bd33e6-4ba1-4d38-428e-08da4f6d7cab
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2022 07:54:48.9224
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Y5gfnpWftIseaIkERQ5pdHctZxJGLdLuk/DlfMAt4KW9Er+VRXoxKX+bxCmJDYygeEAHChLJsUC0tjns7jVLWFr0dwkIq1UiB2FSP2S+0d8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1001MB2308
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.874
 definitions=2022-06-16_04:2022-06-15,2022-06-16 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0 adultscore=0
 mlxlogscore=999 phishscore=0 mlxscore=0 bulkscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000
 definitions=main-2206160029
X-Proofpoint-GUID: xqBMhAWD8cWiLARf4HNjI-OpLxNfZM9M
X-Proofpoint-ORIG-GUID: xqBMhAWD8cWiLARf4HNjI-OpLxNfZM9M
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

On Wed, Jun 15, 2022 at 11:50:35PM +0200, Linus Walleij wrote:
> On Wed, Jun 15, 2022 at 10:26 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
> 
> > The original code works but it's a bit iffy.  The end of loop test
> > should be something like "board_type[i] != '\0'" but instead it is
> > is "i < board_type[i]".  Fortunately, those two tests are equivalent so
> > long as the "board_type" is not an empty string.
> >
> > It's much simpler to just call strreplace() instead.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> 
> I think I just copied this code from the BRCM wifi driver for the combo
> chip, did you patch that too?

Uh, I did but it got lost (my fault).  I will resend that.  Thanks!

regards,
dan carpenter