Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220621134818.11515-1-wangyouwan@uniontech.com>
In-Reply-To: <20220621134818.11515-1-wangyouwan@uniontech.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Tue, 21 Jun 2022 11:39:23 -0700
Message-ID: <CABBYNZ+dnTPvOSzPEPNFJQqBaFF9+F5jfhFj9gUf5sAA06kEGQ@mail.gmail.com>
Subject: Re: [PATCH] device: Fix timeout=1 to remove the device immediately
To:     Youwan Wang <wangyouwan@uniontech.com>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Youwan,

On Tue, Jun 21, 2022 at 6:55 AM Youwan Wang <wangyouwan@uniontech.com> wrot=
e:
>
> =E3=80=80When I use bluetoothctl to remove a device,
> =E3=80=80I find that the device has not been deleted.
>
> =E3=80=80static void set_temporary_timer(device, 0)
> =E3=80=80{
>      ......
>         if (!timeout)
>                 return;
> =E3=80=80=E3=80=80 ......
> =E3=80=80 }
>
> =E3=80=80=E3=80=80Now I want to delete the connected device
>     when call remove.
> =E3=80=80=E3=80=80I don't know whether this modification is
>     feasible, please give me some suggestions.
> ---
>  src/device.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/device.c b/src/device.c
> index 7b451e458..d38ad74fc 100644
> --- a/src/device.c
> +++ b/src/device.c
> @@ -3159,7 +3159,7 @@ void device_remove_connection(struct btd_device *de=
vice, uint8_t bdaddr_type)
>                                                 DEVICE_INTERFACE, "Connec=
ted");
>
>         if (remove_device)
> -               set_temporary_timer(device, 0);
> +               set_temporary_timer(device, 1);
>  }

Don't think this is right, in fact the original code could have been
clearer since all we want is to call clear_temporary_timeout thus why
we passed 0, perhaps you are after the following fix:

https://git.kernel.org/pub/scm/bluetooth/bluez.git/commit/?id=3D5ebc2b5a3e4=
8dbe67a2d315979b096a1b4d1eb99

>  guint device_add_disconnect_watch(struct btd_device *device,
> --
> 2.20.1
>
>
>


--=20
Luiz Augusto von Dentz