Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220629194432.20229-1-brian.gix@intel.com> <20220629194432.20229-2-brian.gix@intel.com>
In-Reply-To: <20220629194432.20229-2-brian.gix@intel.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Wed, 29 Jun 2022 14:07:50 -0700
Message-ID: <CABBYNZ+RutkWSsOqo1Ci5XrvivRr7w+YAXXQ55OPM4MsWpi-Ag@mail.gmail.com>
Subject: Re: [PATCH BlueZ 2/2] core: Fix signed vs unsigned compare
To:     Brian Gix <brian.gix@intel.com>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
        luiz.von.dentz@gmail.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Brian,

On Wed, Jun 29, 2022 at 12:56 PM Brian Gix <brian.gix@intel.com> wrote:
>
> __time_t is not a portable data type, and can cause sign mismatch on
> come compares.
>
> Fixes:
>   CC       src/bluetoothd-device.o
> src/device.c: In function =E2=80=98device_is_name_resolve_allowed=E2=80=
=99:
> src/device.c:4092:17: error: comparison of integer expressions of differe=
nt signedness: =E2=80=98__time_t=E2=80=99 {aka =E2=80=98long int=E2=80=99} =
and =E2=80=98long unsigned int=E2=80=99 [-Werror=3Dsign-compare]
>   if (now.tv_sec >=3D device->name_resolve_failed_time +
>                  ^~
> cc1: all warnings being treated as errors
> ---
>  src/device.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/device.c b/src/device.c
> index 7b451e458..012d73583 100644
> --- a/src/device.c
> +++ b/src/device.c
> @@ -4088,7 +4088,7 @@ bool device_is_name_resolve_allowed(struct btd_devi=
ce *device)
>         /* now >=3D failed_time + name_request_retry_delay, meaning the
>          * period of not sending name request is over.
>          */
> -       if (now.tv_sec >=3D device->name_resolve_failed_time +
> +       if ((unsigned)now.tv_sec >=3D device->name_resolve_failed_time +
>                                         btd_opts.name_request_retry_delay=
)
>                 return true;
>
> --
> 2.36.1

Can't we just use the same type for name_resolve_failed_time?

--=20
Luiz Augusto von Dentz