Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220629191943.17326-1-brian.gix@intel.com>
In-Reply-To: <20220629191943.17326-1-brian.gix@intel.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Wed, 29 Jun 2022 16:49:08 -0700
Message-ID: <CABBYNZLLy2oo8E=1x-TnqLth=0H64qFyWPGrqYDJhtQ5cTpFgw@mail.gmail.com>
Subject: Re: [PATCH BlueZ] monitor: fix usage of size_t %z formater
To:     Brian Gix <brian.gix@intel.com>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
        luiz.von.dentz@gmail.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Brian,

On Wed, Jun 29, 2022 at 12:49 PM Brian Gix <brian.gix@intel.com> wrote:
>
> Some versions of GCC use strict typing for the %z formater, so passing
> an argument of type uint64_t instead of size_t throws an error.
> ---
>  monitor/l2cap.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/monitor/l2cap.h b/monitor/l2cap.h
> index 00a8ffbbd..86113e59d 100644
> --- a/monitor/l2cap.h
> +++ b/monitor/l2cap.h
> @@ -291,7 +291,7 @@ static inline bool l2cap_frame_print_be64(struct l2cap_frame *frame,
>                 return false;
>         }
>
> -       print_field("%s: 0x%zx", label, u64);
> +       print_field("%s: 0x%zx", label, (size_t)u64);
>
>         return true;
>  }
> @@ -320,7 +320,7 @@ static inline bool l2cap_frame_print_le64(struct l2cap_frame *frame,
>                 return false;
>         }
>
> -       print_field("%s: 0x%zx", label, u64);
> +       print_field("%s: 0x%zx", label, (size_t)u64);
>
>         return true;
>  }
> --
> 2.36.1

I suspend we need to use something like PRIu64 macros, like we already
do in some of our code e.g.:

src/adapter.c:          sscanf(rand, "%" PRIu64, &ltk->rand);


-- 
Luiz Augusto von Dentz