Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Brian Gix <brian.gix@intel.com>
To:     linux-bluetooth@vger.kernel.org
Cc:     luiz.von.dentz@gmail.com, brian.gix@intel.com
Subject: [PATCH BlueZ] mesh: Fix potential memory leak
Date:   Thu, 30 Jun 2022 14:13:13 -0700
Message-Id: <20220630211313.210017-1-brian.gix@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

This memory leak will never happen, however since we added a new
return from function that malloc'd memory, the free should still be
done.
---
 mesh/mesh-config-json.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/mesh/mesh-config-json.c b/mesh/mesh-config-json.c
index 5bb1e5ce0..7f46c8582 100644
--- a/mesh/mesh-config-json.c
+++ b/mesh/mesh-config-json.c
@@ -1961,8 +1961,10 @@ bool mesh_config_comp_page_add(struct mesh_config *cfg, uint8_t page,
 	len = (size * 2) + 3;
 	buf = l_malloc(len);
 	ret = snprintf(buf, len, "%2.2x", page);
-	if (ret < 0)
+	if (ret < 0) {
+		l_free(buf);
 		return false;
+	}
 
 	hex2str(data, size, buf + 2, len - 2);
 
-- 
2.36.1