Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp194933imw; Fri, 15 Jul 2022 00:53:13 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uwoyQyVDgW0eymhAVfPRjgAlhe1ExH80+jaBMd3hhIux6FXSfTe501BUFkpbdKJNfXg+nQ X-Received: by 2002:a05:6402:248d:b0:437:dd4c:e70e with SMTP id q13-20020a056402248d00b00437dd4ce70emr16980266eda.75.1657871593136; Fri, 15 Jul 2022 00:53:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657871593; cv=none; d=google.com; s=arc-20160816; b=HtuLhUyaMS03LpcrfHOS/rNkwXyl/PypUxajRpGgfNwxdJlxjgxCmsYcWxoVj6f7+V JMgTuCS/TI1sg2jw5l1Ss14TLcepOY5QgSyTu+O2SpCVRQ4Dt5OEWsIdWN0EVHEirldM BD1VropWkUHf9APy/NF4gNRAhm9xC3siqqc+NRcMjHZRdH2d2O6sQfMF3c3nf2jnmjPy LZd2cT77beQnM58DFO22K6qlob3awCm2/0SVZzZtLbuvAzN+97x3Syf2WzoxrlUth3Kl 1nyQAZ3YqJFCh10zK0w4UkQyVwswpvfetcHmoqzODiW9xas1pp2chVshnNuvbBfN5uu6 WWKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=gvvUpSNEdrF8U7FzrEDBpK1R21Jli10yJG67LcVmV5Q=; b=WWQ2mP2tMJJIZgSK1MEPZYvLbISIvV4zJEQa2EpYEoRW4OUOTTVhIQg3Rf9Eyr/gL0 wP0knHlh196nWEX1BfB+zQiV5+3pvHcISIuflHYq5/KGByMXeQ0qPuO3tSiL/lyxjUYX GWkbrdN30rTjcxwaIlUTYttaLYyvRKI0Re4TtHtMGfNB7nAV6gpWYfYebqon+jrkzpnq /UNj6EtPMG9J/9Wjx1Fp7goBjIe4ipd14rNuZr2Yh8fsv7dK/4orVKXcq+zb6Jb2LtzY 2dN4c2eSEoLhDKH/5cdT41Dg9I0xfsxZ4ZECQX5gGCIx3EyMLefXyOCDuXdi0sx2qsjj e5AA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=BQM5jOQB; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l6-20020aa7c306000000b0043a72613b3asi4837632edq.204.2022.07.15.00.52.38; Fri, 15 Jul 2022 00:53:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=BQM5jOQB; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231947AbiGOHrJ (ORCPT + 99 others); Fri, 15 Jul 2022 03:47:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230151AbiGOHrJ (ORCPT ); Fri, 15 Jul 2022 03:47:09 -0400 Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D27376E87; Fri, 15 Jul 2022 00:47:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1657871228; x=1689407228; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=gvvUpSNEdrF8U7FzrEDBpK1R21Jli10yJG67LcVmV5Q=; b=BQM5jOQB98zyorvfBhgjocrG+XrM1/0OJav4EJxN53uoLqZ5hapYCgJb mKdFTG6YjsWUrJf3+D0frU1bRjsXh1LNPoBTiUwEb28W7r9Hw1gfLgqfO WNIf8sXqdEGP3R1jzBsSyM/FfJKjoMrZQKG4XRU2lnTokbAIVVrHKe8xM I=; Received: from unknown (HELO ironmsg-SD-alpha.qualcomm.com) ([10.53.140.30]) by alexa-out-sd-01.qualcomm.com with ESMTP; 15 Jul 2022 00:47:08 -0700 X-QCInternal: smtphost Received: from unknown (HELO nasanex01a.na.qualcomm.com) ([10.52.223.231]) by ironmsg-SD-alpha.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2022 00:47:08 -0700 Received: from [10.253.39.163] (10.80.80.8) by nasanex01a.na.qualcomm.com (10.52.223.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Fri, 15 Jul 2022 00:47:05 -0700 Message-ID: Date: Fri, 15 Jul 2022 15:47:01 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] Bluetooth: hci_sync: Remove redundant func definition Content-Language: en-US To: Paul Menzel CC: , , , , , , , , , , , References: <1657858487-29052-1-git-send-email-quic_zijuhu@quicinc.com> From: quic_zijuhu In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01a.na.qualcomm.com (10.52.223.231) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org On 7/15/2022 3:34 PM, Paul Menzel wrote: > Dear Zijun, > > > Thank you for the patch. > > Am 15.07.22 um 06:14 schrieb Zijun Hu: >> both hci_request.c and hci_sync.c have the same definition >> for disconnected_accept_list_entries(), so remove a redundant >> copy. > > Please use 75 characters per line for Linux commit message bodies. That way, only two instead of three lines are needed. thanks for your suggestion, correct within v4 sent. could you code review again? >> Signed-off-by: Zijun Hu >> --- >> v1->v2 >>     -remove the func copy within hci_request.c instead of hci_sync.c >>   net/bluetooth/hci_request.c | 18 ------------------ >>   net/bluetooth/hci_request.h |  2 ++ >>   net/bluetooth/hci_sync.c    |  2 +- >>   3 files changed, 3 insertions(+), 19 deletions(-) > > […] > > > Kind regards, > > Paul