Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <72a1d366-ce9f-c8f2-1ca1-f2b191d36ba9@molgen.mpg.de>
Date:   Tue, 19 Jul 2022 21:28:12 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.0.2
Subject: Re: [PATCH] Bluetooth:btrtl:Fix typo in comment
To:     Shaomin Deng <dengshaomin@cdjrlc.com>
References: <20220719154148.16769-1-dengshaomin@cdjrlc.com>
Content-Language: en-US
Cc:     marcel@holtmann.org, johan.hedberg@gmail.com, luiz.dentz@gmail.com,
        linux-bluetooth@vger.kernel.org
From:   Paul Menzel <pmenzel@molgen.mpg.de>
In-Reply-To: <20220719154148.16769-1-dengshaomin@cdjrlc.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Dear Shaomin,


Am 19.07.22 um 17:41 schrieb shaomin Deng:
> Delete the repeated word "that" in comments.

Maybe start your first name with a capital letter?

     git config --global user.name "Shaomin Deng"

In the commit message summary, please add a space after the colons, and 
maybe use:

Bluetooth: btrtl: Remove duplicate *that* in comment

> 
> Signed-off-by: shaomin Deng <dengshaomin@cdjrlc.com>
> ---
>   drivers/bluetooth/btrtl.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
> index 47c28fd8f006..fb52313a1d45 100644
> --- a/drivers/bluetooth/btrtl.c
> +++ b/drivers/bluetooth/btrtl.c
> @@ -330,7 +330,7 @@ static int rtlbt_parse_firmware(struct hci_dev *hdev,
>   	/* Loop from the end of the firmware parsing instructions, until
>   	 * we find an instruction that identifies the "project ID" for the
>   	 * hardware supported by this firwmare file.

firmware

It’d be great if you fixed that in a separate commit.

> -	 * Once we have that, we double-check that that project_id is suitable
> +	 * Once we have that, we double-check that project_id is suitable

It’s a lot of “that”, but it’s actually correct.

>   	 * for the hardware we are working with.
>   	 */
>   	while (fwptr >= btrtl_dev->fw_data + (sizeof(*epatch_info) + 3)) {


Kind regards,

Paul