Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 20 Jul 2022 14:23:49 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Marcel Holtmann <marcel@holtmann.org>,
        Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc:     Johan Hedberg <johan.hedberg@gmail.com>,
        linux-bluetooth@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH] Bluetooth: clean up error pointer checking
Message-ID: <YtflxRosxskh2CoH@kili>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/mBxFoaeM1cgMEKuyZfoRno8uuBuWJ8dTrBAxW5KeC0+eEDzxzfjjcOwoNiw?=
 =?us-ascii?Q?dvWup6CSndI4+P3U8ydcm/nCZRzAzJHKBY7+Ti+XFje0xim2a6e4vnyuczXS?=
 =?us-ascii?Q?EV96NE05cBxDF595+GDVJi9fyJh1bto5OoWbHPstEBEihvVI9Gm6+h5DFbFs?=
 =?us-ascii?Q?ymsDYRQ1UpbQYnk+s0Ket57p0URoATpLk64ex/bVAxqLHtsnn4PfHGTCkdpF?=
 =?us-ascii?Q?gf/QPmJlLpekNePmaaox3iJ+RPfHHC/9U8nytthykbVI6mv3su++BqzJ7qy5?=
 =?us-ascii?Q?KnD9vLh7IQcmjdtoii/I+M/U75h/Tb53ZctS09ScUpGsoa4CAYMjZEuDAl+i?=
 =?us-ascii?Q?yuoZqW/uS5dQI7uwoRpHR35eZOuWMJT4lMPIRzBwBry1A0C1pJqfCoA30dWb?=
 =?us-ascii?Q?sC1vjno+zcS7iKFuU1yCJlJv6X2OIOSpgGlsba3b369807692Fxg9S+ZFJEZ?=
 =?us-ascii?Q?6ZfYie/eSQQR+OycZaK6zvFASgSwDw12gdMDk6NetGZd51qUtGKX4dgYQ22H?=
 =?us-ascii?Q?wi2ed6tgK8mlIs5dLuvHZBXTlOEi5sheDH+LRSfCtZ+8Yey9n6FITKKqQc+o?=
 =?us-ascii?Q?F16PzPDm7J04oIwmt4wvHtU3cs48lyB75dH0QAWpIB6CmIL7JETsbe3rYem5?=
 =?us-ascii?Q?LUZxddkk39wyBUWjb4rdYRCZdpb0EoaThGzLpO1Hlkm++ImiVsl5XYIetX6L?=
 =?us-ascii?Q?VQrVBNdiMYAlQAw3kuAT2S+fobzgYucAznyvYwk+2vwK+pzCxTk7jbvvgtcc?=
 =?us-ascii?Q?msJdqkeqfj+592v9PPLxH5ezvKEv6ERdP6Lsh0kRV7coS2scJsHDCY8T4G4J?=
 =?us-ascii?Q?nR90W/PYRnz1ryn2X6RBJNjJBRGiQNlHJCT4Tiv3lFyDyYCt1RCrVtU4SYte?=
 =?us-ascii?Q?RB81nBL1y3yKzNascu4Mi0Sp7MR6PBj4xEPYeu65XpEKpTnS7Vp6N7hd+JAU?=
 =?us-ascii?Q?36eFX2tKru1nkQifyyYme230jppnha5nA6EvM0zN++W1gIF7rDp0klxlCa5S?=
 =?us-ascii?Q?ND2U1/3gyqYO/EzvaVt4lxljVeJrivqu1kMmvmV/agyVfTmFXrL64SlkmulI?=
 =?us-ascii?Q?1MY6JxzVOftI7vzsOUw3jjN3RLROvUsWfQWw2JDNp0q2RyH8Iq0U2kMu75Zt?=
 =?us-ascii?Q?XyDgM8vEm+iK6JHqoNLNVgEgUAxnaAnN78yAMj/KKczbrGFmP77JHL2JO6og?=
 =?us-ascii?Q?tvsO8MKXlljw9CLWfHWSambmJEd4nhF9S6VBSQo3wjt4xaWgMBLYfEsOvtJ6?=
 =?us-ascii?Q?VjK+cHz9+jeZ27j7LT7cKCB8FrH5injO7blDjMekTfRIcWuxcjfB3u7bkXZk?=
 =?us-ascii?Q?L5lA1Cw60J4+bpqXk81mXvUTwsm1avrnAX6ysp1lh2LgnhONqysRJUXYCwIP?=
 =?us-ascii?Q?KGWQAUcI7KDfDv0L34/oRh3OoC2+UqDFBWHhO7ptuYCjuAYnY3hDi7j13M/B?=
 =?us-ascii?Q?5o+wLLsnewTgquUnyn7SXuhHR8OxKxOOyYmpTbfIRoSIE1zMGAbsvnVn/psp?=
 =?us-ascii?Q?knMxtOqQKds4c8NF0UsZ/CbMYE6r3knxI5ShRzNjTSJTYCYRSq5ZQJid3tR3?=
 =?us-ascii?Q?LHjN7ienFRjaWEui756z7sjD6zXt1ue3Gm7XWh2ZZrTRAz0t6NzdA3qyd4k0?=
 =?us-ascii?Q?3w=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 45ebf124-4905-417d-e9fe-08da6a4256f6
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2022 11:23:58.7160
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OxMA57dPZPtovfIH6RU2Sg0Znf5dVExrPQfM4JNlHevCUwMtZXreVx2mVL+fJxmX34Ag4b8L/pLT5GOeHuflz5JRtXUp6nbYVh/TF2FKRmI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB4151
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-07-20_05,2022-07-20_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 malwarescore=0
 mlxscore=0 phishscore=0 mlxlogscore=999 suspectscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2207200047
X-Proofpoint-GUID: DqTwAfOpENdrcOMrVW6aBs4JLU-GtONF
X-Proofpoint-ORIG-GUID: DqTwAfOpENdrcOMrVW6aBs4JLU-GtONF
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org

The bt_skb_sendmsg() function can't return NULL so there is no need to
check for that.  Several of these checks were removed previously but
this one was missed.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 include/net/bluetooth/bluetooth.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/net/bluetooth/bluetooth.h b/include/net/bluetooth/bluetooth.h
index 6b48d9e2aab9..a8b52175af05 100644
--- a/include/net/bluetooth/bluetooth.h
+++ b/include/net/bluetooth/bluetooth.h
@@ -494,7 +494,7 @@ static inline struct sk_buff *bt_skb_sendmmsg(struct sock *sk,
 	struct sk_buff *skb, **frag;
 
 	skb = bt_skb_sendmsg(sk, msg, len, mtu, headroom, tailroom);
-	if (IS_ERR_OR_NULL(skb))
+	if (IS_ERR(skb))
 		return skb;
 
 	len -= skb->len;
-- 
2.35.1