Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220614145253.132230-1-soenke.huster@eknoes.de> <67219c6e-7eef-ee5c-693c-215a4d4c1b3e@eknoes.de>
In-Reply-To: <67219c6e-7eef-ee5c-693c-215a4d4c1b3e@eknoes.de>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Fri, 22 Jul 2022 10:59:35 -0700
Message-ID: <CABBYNZ+x1eph+bzSB2SU1qNe4M8K-rtinSrOrq4=fTW+U9uEyg@mail.gmail.com>
Subject: Re: [PATCH] Bluetooth: virtio_bt: Use skb_put to set length
To:     =?UTF-8?Q?S=C3=B6nke_Huster?= <soenke.huster@eknoes.de>
Cc:     Marcel Holtmann <marcel@holtmann.org>,
        Johan Hedberg <johan.hedberg@gmail.com>,
        "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi S=C3=B6nke,

On Fri, Jul 22, 2022 at 4:59 AM S=C3=B6nke Huster <soenke.huster@eknoes.de>=
 wrote:
>
> On 14.06.22 16:52, Soenke Huster wrote:
> > By using skb_put we ensure that skb->tail is set
> > correctly. Currently, skb->tail is always zero, which
> > leads to errors, such as the following page fault in
> > rfcomm_recv_frame:
> >
> >     BUG: unable to handle page fault for address: ffffed1021de29ff
> >     #PF: supervisor read access in kernel mode
> >     #PF: error_code(0x0000) - not-present page
> >     RIP: 0010:rfcomm_run+0x831/0x4040 (net/bluetooth/rfcomm/core.c:1751=
)
> >
> > Signed-off-by: Soenke Huster <soenke.huster@eknoes.de>
> > ---
> >  drivers/bluetooth/virtio_bt.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/bluetooth/virtio_bt.c b/drivers/bluetooth/virtio_b=
t.c
> > index 67c21263f9e0..fd281d439505 100644
> > --- a/drivers/bluetooth/virtio_bt.c
> > +++ b/drivers/bluetooth/virtio_bt.c
> > @@ -219,7 +219,7 @@ static void virtbt_rx_work(struct work_struct *work=
)
> >       if (!skb)
> >               return;
> >
> > -     skb->len =3D len;
> > +     skb_put(skb, len);
> >       virtbt_rx_handle(vbt, skb);
> >
> >       if (virtbt_add_inbuf(vbt) < 0)
>
> Are there any issues with it, or is there another reason why it is not me=
rged yet?

It appears it was removed from PW due to 30 days inactivity, when that
happens you should resend the patch since it needs to be retested by
CI.

--=20
Luiz Augusto von Dentz