Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp5155160rwb; Wed, 17 Aug 2022 12:05:04 -0700 (PDT) X-Google-Smtp-Source: AA6agR6f6/V86b392GblhcM9V6JeIniqY+3RY3PvjPlIfhY/E+mu2XOQ27akxbPDkp+xSIciHwZj X-Received: by 2002:a05:6402:11cf:b0:43d:fc84:c51a with SMTP id j15-20020a05640211cf00b0043dfc84c51amr23587312edw.80.1660763104030; Wed, 17 Aug 2022 12:05:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660763104; cv=none; d=google.com; s=arc-20160816; b=wG0ZpJzb/gUoWa2wZzOoiUoo9Rh2EMf9gRbg7WLVx8FgMm5uzhZ+IgytJaih+uFI+J 3aibI6FuxFk7WlxbAryf0aliqBs86gnRC3GIfCCREr5YCsJlaSPaBChD3f2nkIkctpyV HskbkDPBhlGej15mn8UPse7Hq3L0oJhM1Dh0cYoX6UI99lWTs+5ng9sgBvmnRclM2f2N +J/vOw/wu/ExN35i9cIKSaGnTc7eL2lgmfsWdUuvLyDnLn9XJPBZdWT3wiAs8C5GBhAa 2aEDNW2+VHpB+n5Ejy8vrBohtnfYpcSHdH7g+UvInTeQF/mpBegbK75vIuxXbq4gpZeH tuWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=qnLgrkCwVqBzE0LOBvrMvSG0dYVD1oWrpbEgq2k6sqI=; b=KSYzIWeJce/Vi5Ojej9j+Nj7RELyIc302EIrkuNcU1/C3+QmUuoT6wcq5FbPZdy2es vRSEeR3qtOxN1hUKsCiV0QtM4GpteE6tBfvRViZi0CGIWlZPy2eiYT+F71BVRN30vOc/ WHL4MG8Ta2TmsBU9MLz0tFljhJJX06Ol1sQAOe7z9EG19520zrYqEABHwXX4OSdyuhzY S9/qaeX3pFv0ZCdbwlzBZj7IRfSpBR6vFLjdRpwgnE2JqsJdQ/FOAEPwiJzM2T22Rqrf srreRaOJmk5lYZytU9WDGwpHO3XykFfeliivvliwAmJ/Ff8mWnisS5+5+kbrvn+U8m2x zg4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ewjRLEHv; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hv8-20020a17090760c800b0073156e618a1si13635095ejc.357.2022.08.17.12.04.21; Wed, 17 Aug 2022 12:05:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ewjRLEHv; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241315AbiHQSwb (ORCPT + 99 others); Wed, 17 Aug 2022 14:52:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241300AbiHQSwb (ORCPT ); Wed, 17 Aug 2022 14:52:31 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E328A3D6A; Wed, 17 Aug 2022 11:52:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AAB2961446; Wed, 17 Aug 2022 18:52:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 02EE6C433D7; Wed, 17 Aug 2022 18:52:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660762349; bh=RR33wIOlyo9eMIkzmh0mFx+gISQrdv7F4Oqj1rsVrls=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=ewjRLEHvK5mf5HNdt8uN0i2auiMMJL/abHSO0tZhFBtZCdqUL2gHWoMC3BCOSaiFV fHNf4HtQwTuT18iTJ0rXY0BZCJQSScNGeS9o8lXeNWhSHmn066mmdPMoNdfz6qcX17 z9rsxGTKL04zbP9sThuO9coCE4FwO0FGMn70Y3PytUltFoSM6inbpAQsW92AqWmJA+ TgEFbr3E7FeQ8hEmfOgF8ceNVbabViy+40W8bSG36mleCOFhCHrwji6QQZy8rt/JQ8 Q2juUM7SxEdX+qeiLIRXz2S7t7ctqgyS+/xx9Z4WoljBk6wRYGo4HrK7fH2qaZCKjv 6zfZQ1Md/OZ2w== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id CED06E2A04C; Wed, 17 Aug 2022 18:52:28 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] Bluetooth: hci_sync: fix double mgmt_pending_free() in remove_adv_monitor() From: patchwork-bot+bluetooth@kernel.org Message-Id: <166076234884.20898.8598584910836798147.git-patchwork-notify@kernel.org> Date: Wed, 17 Aug 2022 18:52:28 +0000 References: In-Reply-To: To: Tetsuo Handa Cc: syzbot+915a8416bf15895b8e07@syzkaller.appspotmail.com, davem@davemloft.net, edumazet@google.com, johan.hedberg@gmail.com, kuba@kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, luiz.dentz@gmail.com, marcel@holtmann.org, netdev@vger.kernel.org, pabeni@redhat.com, syzkaller-bugs@googlegroups.com X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hello: This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz : On Wed, 17 Aug 2022 20:14:36 +0900 you wrote: > syzbot is reporting double kfree() at remove_adv_monitor() [1], for > commit 7cf5c2978f23fdbb ("Bluetooth: hci_sync: Refactor remove Adv > Monitor") forgot to remove duplicated mgmt_pending_remove() when > merging "if (err) {" path and "if (!pending) {" path. > > Link: https://syzkaller.appspot.com/bug?extid=915a8416bf15895b8e07 [1] > Reported-by: syzbot > Fixes: 7cf5c2978f23fdbb ("Bluetooth: hci_sync: Refactor remove Adv Monitor") > Signed-off-by: Tetsuo Handa > > [...] Here is the summary with links: - Bluetooth: hci_sync: fix double mgmt_pending_free() in remove_adv_monitor() https://git.kernel.org/bluetooth/bluetooth-next/c/ae2b5c97cd40 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html