Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c323f4ed-1083-8eb6-95ba-10b0def2c936@infradead.org>
Date:   Thu, 18 Aug 2022 15:09:52 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] Bluetooth: move from strlcpy with unused retval to
 strscpy
Content-Language: en-US
To:     Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
        Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Marcel Holtmann <marcel@holtmann.org>,
        Johan Hedberg <johan.hedberg@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
        "open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>
References: <20220818210207.8323-1-wsa+renesas@sang-engineering.com>
 <CABBYNZ+Z=3kiA1jSiGH1KQCG6SHSDPp6MCA1pqU8CjtGRNYqqQ@mail.gmail.com>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <CABBYNZ+Z=3kiA1jSiGH1KQCG6SHSDPp6MCA1pqU8CjtGRNYqqQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 8/18/22 15:07, Luiz Augusto von Dentz wrote:
> Hi Wolfram,
> 
> On Thu, Aug 18, 2022 at 2:05 PM Wolfram Sang
> <wsa+renesas@sang-engineering.com> wrote:
>>
>> Follow the advice of the below link and prefer 'strscpy' in this
>> subsystem. Conversion is 1:1 because the return value is not used.
>> Generated by a coccinelle script.
> 
> The link below doesn't seem to work.

Works for me.

>> Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/
>> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
>> ---
>>  net/bluetooth/hidp/core.c | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/net/bluetooth/hidp/core.c b/net/bluetooth/hidp/core.c
>> index 5940744a8cd8..cc20e706c639 100644
>> --- a/net/bluetooth/hidp/core.c
>> +++ b/net/bluetooth/hidp/core.c
>> @@ -83,14 +83,14 @@ static void hidp_copy_session(struct hidp_session *session, struct hidp_conninfo
>>                 ci->product = session->input->id.product;
>>                 ci->version = session->input->id.version;
>>                 if (session->input->name)
>> -                       strlcpy(ci->name, session->input->name, 128);
>> +                       strscpy(ci->name, session->input->name, 128);
>>                 else
>> -                       strlcpy(ci->name, "HID Boot Device", 128);
>> +                       strscpy(ci->name, "HID Boot Device", 128);
>>         } else if (session->hid) {
>>                 ci->vendor  = session->hid->vendor;
>>                 ci->product = session->hid->product;
>>                 ci->version = session->hid->version;
>> -               strlcpy(ci->name, session->hid->name, 128);
>> +               strscpy(ci->name, session->hid->name, 128);
>>         }
>>  }
>>
>> --
>> 2.35.1
>>
> 
> 

-- 
~Randy