Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f9fd47a4-e5fc-5640-de71-dee1d52da2a8@molgen.mpg.de>
Date:   Mon, 22 Aug 2022 08:15:57 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.1.2
Subject: Re: [Bluez PATCH] adapter: Reset pending settings when receiving MGMT
 error
To:     Archie Pusaka <apusaka@google.com>
Cc:     linux-bluetooth@vger.kernel.org,
        Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
        Marcel Holtmann <marcel@holtmann.org>,
        chromeos-bluetooth-upstreaming@chromium.org,
        Archie Pusaka <apusaka@chromium.org>,
        Sonny Sasaka <sonnysasaka@chromium.org>
References: <20220822125221.Bluez.1.I541cbea9d6295f531c796bf3bda96b22db76bc19@changeid>
Content-Language: en-US
From:   Paul Menzel <pmenzel@molgen.mpg.de>
In-Reply-To: <20220822125221.Bluez.1.I541cbea9d6295f531c796bf3bda96b22db76bc19@changeid>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Dear Archie,


Thank you for the patch.


Am 22.08.22 um 06:53 schrieb Archie Pusaka:
> From: Archie Pusaka <apusaka@chromium.org>

I think the tag in the email subject needs to be [PATCH BlueZ] to be 
detected by the build bot.

> We set the pending settings flag when sending MGMT_SETTING_*
> commands to the MGMT layer and clear them when receiving success
> reply, but we don't clear them when receiving error reply. This
> might cause a setting to be stuck in pending state.

Were you able to reproduce a problem on real hardware?

> Therefore, also clear the pending flag when receiving error.
> Furthermore, this patch also postpone setting the pending flag

postpone*s*

> until we queue the MGMT command in order to avoid setting it too
> soon but we return early.

Maybe add a comment, that how you tested this?

> Reviewed-by: Sonny Sasaka <sonnysasaka@chromium.org>
> 
> ---
> 
>   src/adapter.c | 45 +++++++++++++++++++++++++++++++++++++--------
>   1 file changed, 37 insertions(+), 8 deletions(-)

[…]


Kind regards,

Paul