Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220822023242.18162-1-ronan@rjp.ie>
In-Reply-To: <20220822023242.18162-1-ronan@rjp.ie>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Mon, 22 Aug 2022 15:55:02 -0700
Message-ID: <CABBYNZLe2ZhgQUVs3nN_7mVxnm90n31NhUMXF7mzqUsko96-3w@mail.gmail.com>
Subject: Re: [PATCH BlueZ] zsh: drop no more arguments message
To:     Ronan Pigott <ronan@rjp.ie>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Ronan,

On Sun, Aug 21, 2022 at 7:33 PM Ronan Pigott <ronan@rjp.ie> wrote:
>
> This usage of the _message as a completion function is invalid, and
> will result in an error if invoked by _arguments when the user has a
> format style set for completion messages.
>
> We can just drop this message, since it is not necessary.

It might be better to include the output of zsh when it fails to
auto-complete, or actually a pre and post patch output.

> ---
>  completion/zsh/_bluetoothctl | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/completion/zsh/_bluetoothctl b/completion/zsh/_bluetoothctl
> index bf35e503e..610ca2b8d 100644
> --- a/completion/zsh/_bluetoothctl
> +++ b/completion/zsh/_bluetoothctl
> @@ -68,8 +68,7 @@ _bluetoothctl() {
>                 '(info)'{-m,--monitor}'[Enable monitor output]' \
>                 + 'command' \
>                 '(info):command:->command' \
> -               '(info):: :->argument' \
> -               ': :_message "no more arguments"'
> +               '(info):: :->argument'
>
>         if [[ $state == "command" ]]; then
>                 _describe -t commands 'command' all_commands
> --
> 2.37.2
>


-- 
Luiz Augusto von Dentz