Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <db39101f70c945026e76d7b49ee358d9a2330358.camel@hadess.net>
 <6422b1f3f94e959917f919af20a2aa43b4c13a89.camel@hadess.net> <CABBYNZ+TKBSHr67Avm+g-_ce8bKE17OSp9xMayJk_y--MsAuDQ@mail.gmail.com>
In-Reply-To: <CABBYNZ+TKBSHr67Avm+g-_ce8bKE17OSp9xMayJk_y--MsAuDQ@mail.gmail.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Thu, 25 Aug 2022 16:10:48 -0700
Message-ID: <CABBYNZKpB2p5mh8q6he21MM1m3qapwYccsEgUa9q5OrbjRnZzQ@mail.gmail.com>
Subject: Re: [PATCH] adapter: Implement PowerState property
To:     Bastien Nocera <hadess@hadess.net>,
        Archie Pusaka <apusaka@google.com>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Archie and Bastien,

On Thu, Aug 25, 2022 at 4:06 PM Luiz Augusto von Dentz
<luiz.dentz@gmail.com> wrote:
>
> Hi Bastien,
>
> On Thu, Aug 25, 2022 at 8:32 AM Bastien Nocera <hadess@hadess.net> wrote:
> >
> > On Thu, 2022-08-25 at 15:26 +0200, Bastien Nocera wrote:
> > > This property should allow any program to show the transitional
> > > state,
> > > not just the one that requested the change, and will also show
> > > transitional states that were the results of other system changes,
> > > like
> > > rfkill changes.
> >
> > Looks like the bot doesn't like where I put those comments.
> >
> > If anyone can comment on the API I used, and I'll iterate the actual
> > implementation. I'd like the API to be settled by the time GNOME 43
> > ships, so we can rely on it there.
>
> I wonder what are you actually after with these changes, in most cases
> I'd say the changes shall just be queued, anyway perhaps the problem
> was something related to:
>
> https://git.kernel.org/pub/scm/bluetooth/bluez.git/commit/?id=ede7b915980fbc80eff80aa189c35ca016956c61

Btw, I think this shows that perhaps it would be best practice to
create a github issue when there are bugs for Gnome/Chrome OS so we
can properly use the Fixes: tag to close them which makes it easier
for downstream to find out if a similar issue was fixed and attempt to
reuse the same fix.

-- 
Luiz Augusto von Dentz