Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7cc9c749f6e87e5feff30c16422665f10549def6.camel@hadess.net>
Subject: Re: [PATCH] adapter: Implement PowerState property
From:   Bastien Nocera <hadess@hadess.net>
To:     Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Date:   Tue, 30 Aug 2022 18:59:25 +0200
In-Reply-To: <039331637535e9cb0c1f9df777cd18d5e34cfe27.camel@hadess.net>
References: <db39101f70c945026e76d7b49ee358d9a2330358.camel@hadess.net>
         <CABBYNZL+NZ_NR8bx+CaayZis4oRywGvqYN8umqaCYEpp3uOwMw@mail.gmail.com>
         <039331637535e9cb0c1f9df777cd18d5e34cfe27.camel@hadess.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2022-08-29 at 11:47 +0200, Bastien Nocera wrote:
> The rfkill calls made by GNOME are usually sent to all the rfkill
> devices, rather than targeted at blocking a single adapter. So the
> adapter state isn't super interesting in this case, as all the
> devices
> will be either blocked (computer with no platform rfkill), or gone
> from
> the USB bus (computer with a platform rfkill).
> 
> 
> The good thing about using a string property here is that we can
> extend
> it. One thing we can do though, to make extensibility easier, is take
> a
> leaf out of the icon naming specification, and use prefixes to encode
> the expected state in case the software isn't new enough to know
> about
> a property.
> 
> For example:
> - "on"
> - "off"
> - "on-disabling" (transitioning from on to off)
> - "off-enabling" (transitioning from off to on)
> 
> So we could easily add:
> - "off-rfkill" (off and blocked)
> 
> Let me know what you think.

Poking again, as I really need to land this soon (and by soon I mean
last week ;)