Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <db39101f70c945026e76d7b49ee358d9a2330358.camel@hadess.net>
 <CABBYNZL+NZ_NR8bx+CaayZis4oRywGvqYN8umqaCYEpp3uOwMw@mail.gmail.com>
 <039331637535e9cb0c1f9df777cd18d5e34cfe27.camel@hadess.net> <7cc9c749f6e87e5feff30c16422665f10549def6.camel@hadess.net>
In-Reply-To: <7cc9c749f6e87e5feff30c16422665f10549def6.camel@hadess.net>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Tue, 30 Aug 2022 10:35:46 -0700
Message-ID: <CABBYNZJEJJRnu+O9F2ow6WrnTGdV0Qxt5VSSM4oKbQQc+Ruq8g@mail.gmail.com>
Subject: Re: [PATCH] adapter: Implement PowerState property
To:     Bastien Nocera <hadess@hadess.net>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Bastien,

On Tue, Aug 30, 2022 at 9:59 AM Bastien Nocera <hadess@hadess.net> wrote:
>
> On Mon, 2022-08-29 at 11:47 +0200, Bastien Nocera wrote:
> > The rfkill calls made by GNOME are usually sent to all the rfkill
> > devices, rather than targeted at blocking a single adapter. So the
> > adapter state isn't super interesting in this case, as all the
> > devices
> > will be either blocked (computer with no platform rfkill), or gone
> > from
> > the USB bus (computer with a platform rfkill).
> >
> >
> > The good thing about using a string property here is that we can
> > extend
> > it. One thing we can do though, to make extensibility easier, is take
> > a
> > leaf out of the icon naming specification, and use prefixes to encode
> > the expected state in case the software isn't new enough to know
> > about
> > a property.
> >
> > For example:
> > - "on"
> > - "off"
> > - "on-disabling" (transitioning from on to off)
> > - "off-enabling" (transitioning from off to on)
> >
> > So we could easily add:
> > - "off-rfkill" (off and blocked)
> >
> > Let me know what you think.
>
> Poking again, as I really need to land this soon (and by soon I mean
> last week ;)

off-rfkill sounds fine to me, btw introduce it as experimental so we
can still make changes if need to.

-- 
Luiz Augusto von Dentz