Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <01070182f561c630-852e0333-6f04-448b-b064-46a2f000e860-000000@eu-central-1.amazonses.com>
In-Reply-To: <01070182f561c630-852e0333-6f04-448b-b064-46a2f000e860-000000@eu-central-1.amazonses.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Wed, 31 Aug 2022 13:18:00 -0700
Message-ID: <CABBYNZJGc2Y3UULighw95un9mb8khLM2dfTOB3jRV8D3ksVDXg@mail.gmail.com>
Subject: Re: [PATCH] plugins: Do not try to autopair with Nissan Connect devices
To:     Florian Leeber <florian@ubports.com>
Cc:     "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Florian,

On Wed, Aug 31, 2022 at 12:44 PM Florian Leeber <florian@ubports.com> wrote=
:
>
> It seems that Nissan Connect carkits a) do not use 0000 but 1234 as
> default code
> but also b) the autopair plugin is not allowed to make a second attempt
> to pair.
> Let=C2=B4s try to not use the autopairing at all for those devices.
> ---
>   plugins/autopair.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/plugins/autopair.c b/plugins/autopair.c
> index 0b09e89..6bf07e3 100644
> --- a/plugins/autopair.c
> +++ b/plugins/autopair.c
> @@ -66,6 +66,9 @@ static ssize_t autopair_pincb(struct btd_adapter *adapt=
er,
>          /* The iCade shouldn't use random PINs like normal keyboards */
>          if (strstr(name, "iCade") !=3D NULL)
>                  return 0;
> +       /* Nissan Connect carkits use PIN 1234 but refuse a retry */
> +       if (strstr(name, "NISSAN CONNECT") !=3D NULL)
> +               return 0;

Well this is already starting to grow which imo defeats the purpose of
hardcoding directly on the code so perhaps we could have a section
e.g. [Autopair] where one can enter device names that shall not use
defaults PINs, or may an entry where one can add its own specific PIN
sequence for a given device name including none:

[Autopair]
PIN=3D0000,1234
# The iCade shouldn't use random PINs like normal keyboards
iCade=3D
# Nissan Connect carkits use PIN 1234 but it refuses retries
NISSAN CONNECT=3D1234

With this the logic is check if there is an entry for the device name
and then use as PIN otherwise use the PIN entry (if not defined use
the current settings as default).

>          /* This is a class-based pincode guesser. Ignore devices with an
>           * unknown class.
> --
> 2.17.1
>


--=20
Luiz Augusto von Dentz