Received: by 2002:a05:6358:bb9e:b0:b9:5105:a5b4 with SMTP id df30csp1553761rwb; Sat, 3 Sep 2022 19:28:09 -0700 (PDT) X-Google-Smtp-Source: AA6agR5w9v9bmLNskP20hRr5jXxpQ1pp1zXFkSEYmS+3NKH1c1sYRfiaBAenRlv6yEY8etAOOxkg X-Received: by 2002:a17:907:8a09:b0:731:610:ff8d with SMTP id sc9-20020a1709078a0900b007310610ff8dmr31349940ejc.399.1662258489651; Sat, 03 Sep 2022 19:28:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662258489; cv=none; d=google.com; s=arc-20160816; b=HybO+82MY/H1tz+/E9Bzca/bsqRgMuhzFPLLR9g9AMSU4aQtlHTJIg5wcWkxFlfzhJ aeRWC9KktEbjMWSyi+CZ9FmOS0YiM7zqBV+caoRna56fMwn1aQdyaWs0uvjmnoOtOsA4 hIxbRAy9xDXbeTAn0G1fjC4JugML1tjawU+RDSpZijqRTHhLdr4IaGgWeszirWZKY0R4 43ky+W7NFj3Pd3VbNAaf+1nN7SMB2vk/Jldj/75W429K8eeLGXgjxkajFecKtwH3ONkk 2OuHyu2/kxUtK16hV9pXTUJQFXjcDOtjwjqbKjQq9JjSqNFKHJpBPNgJdfxdT71k0T8r STWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:sender:dkim-signature; bh=lnOYFop6nDe6Di7kJuCsUPPcQ6Qykx7nWA9Dngo7JWw=; b=gsci6zG9s7oPOja4TGkp31HHY5vUFwibueIeNPbGgUgs0i8XqZ/wGwZbWzPWr8HFOH WXNW8IlsG0L/tg3Smo0iiOrdfvkorLD0C34rfDrZ1wlTskrdghrjREiAW49+hhLroarY 3SbDwprxGB/+WOj9n8EKxBgGahR/xt8s4pfS6Y4Wh3TBWFufg1/k+A11N8b6Ev2BlKio 5YbTivo3eVQDsWXtvrx5NOtfhnWPeeSg1lps7WmovXN9CKO2MMT7vVs+yqWmr8Bxezne hR0fhCdAzA7BkCOp142IDdR9gC2Wrzgaf2eaGQFxbXGveqLARMUivEZ8D75gXb7bIyqq 1hYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=LlhRKtSE; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v10-20020a50954a000000b00446d2c52ca7si4367422eda.127.2022.09.03.19.27.38; Sat, 03 Sep 2022 19:28:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=LlhRKtSE; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229677AbiIDCVH (ORCPT + 99 others); Sat, 3 Sep 2022 22:21:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229632AbiIDCVG (ORCPT ); Sat, 3 Sep 2022 22:21:06 -0400 Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A962A474D7 for ; Sat, 3 Sep 2022 19:21:01 -0700 (PDT) Received: by mail-pl1-x635.google.com with SMTP id jm11so5411316plb.13 for ; Sat, 03 Sep 2022 19:21:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date; bh=lnOYFop6nDe6Di7kJuCsUPPcQ6Qykx7nWA9Dngo7JWw=; b=LlhRKtSE4ukyK5c3S+0h0jmC+oHpfgACLSS1e4fU+2uOpiiZDV+LSetVEcuYg2ZPr5 XD7ATm8Ry/s5zf5VvTNNXobfYNjXXK3LuxTHgfGq+T+nSRYSB6W/9Uk9eFbDFUtjOOu0 AU9ci+BO0uK/dJ91cS6G5xTMTXk51AdRz9WlRusOoPY9icQ/w06mjv8GYfb1y5s5Og79 MpHQ1+QuiOYjj+MswyU5LtvEJ5R+lpEfSu0gluRPTSPDoTtsOazyeLWiluhiS0sqyjP+ g9HvVI+3g3jM5Am1TAF+YHfo+FDnJ5eH7Od7aDC7zzjAx1jGe200OSyXNV3BOXuPo04+ Uz4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date; bh=lnOYFop6nDe6Di7kJuCsUPPcQ6Qykx7nWA9Dngo7JWw=; b=o1KPIG3CqNSF0JOlMyFQV8+kscC56PtbeK/Rr3AY34UxKaz4LXxXGeLgQXlU4gtGqo cVeht56D4fY/+jGX7p4ht/7B86QsVEiWGzdrs7GDFGwUgV3dAQKm+sHtUUHBeAji1ifA TDrqhAvg6szAafdFIQTXldVlz0BdHii1cyD4NTwGdlOwWMnB4TaUBgUySI35sWpA5lHt m5pJ4nNd0sLhIudZ60Ysc62tCftuV6Ysp0LpT9BVSnvP8gsbAwdS5a2nmBqqgESxt8Ec 2A2tDUV5cPIe1sfhrzSFfQGO4xO+aMObwVpse6uwuNTi3qRj9kIZBbiA5M7RPV9eJgy8 e9Mw== X-Gm-Message-State: ACgBeo14ZzhY0MtIm4ctTRdltu7FB2bR0oo6EPom+YkWEqQLzwx/K+ne Q79Ku+ebJO3xsS3Xm9Jxhho= X-Received: by 2002:a17:902:a384:b0:173:4085:23d8 with SMTP id x4-20020a170902a38400b00173408523d8mr41725872pla.143.1662258060924; Sat, 03 Sep 2022 19:21:00 -0700 (PDT) Received: from localhost ([2620:10d:c090:400::5:8793]) by smtp.gmail.com with ESMTPSA id k62-20020a17090a4cc400b002004380686bsm356432pjh.46.2022.09.03.19.21.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Sep 2022 19:21:00 -0700 (PDT) Sender: Tejun Heo Date: Sat, 3 Sep 2022 16:20:58 -1000 From: Tejun Heo To: Luiz Augusto von Dentz Cc: Tetsuo Handa , Marcel Holtmann , Johan Hedberg , Schspa Shi , syzbot , syzkaller-bugs@googlegroups.com, Lai Jiangshan , "linux-bluetooth@vger.kernel.org" Subject: Re: [PATCH] Bluetooth: use hdev->workqueue when queuing hdev->{cmd,ncmd}_timer works Message-ID: References: <00000000000016512d05e76bd837@google.com> <733e6931-aa66-5295-d8a8-49063b7347f1@I-love.SAKURA.ne.jp> <289ba1a9-e4f7-d0b5-545e-a98dcf365c68@I-love.SAKURA.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hello, On Sat, Sep 03, 2022 at 07:11:18PM -0700, Luiz Augusto von Dentz wrote: > And we can check for __WQ_DRAINING? Anyway checking Please don't do that. That's an internal flag. It shouldn't be *that* difficult to avoid this without peeking into wq internal state. Thanks. -- tejun