Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220915095412.462210-1-sathish.narasimman@intel.com> <63230e51.050a0220.6c72d.5248@mx.google.com>
In-Reply-To: <63230e51.050a0220.6c72d.5248@mx.google.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Thu, 15 Sep 2022 14:00:51 -0700
Message-ID: <CABBYNZJaGkWt4zSZyFhsDTGG-_vBSTmwzzrtnbiP6M_fvJyUXA@mail.gmail.com>
Subject: Re: [BlueZ,v2,1/4] lib/uuid: Add VCS UUIDs
To:     linux-bluetooth@vger.kernel.org
Cc:     sathish.narasimman@intel.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Sathish,

On Thu, Sep 15, 2022 at 4:41 AM <bluez.test.bot@gmail.com> wrote:
>
> This is automated email and please do not reply to this email!
>
> Dear submitter,
>
> Thank you for submitting the patches to the linux bluetooth mailing list.
> This is a CI test results with your patch series:
> PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=677268
>
> ---Test result---
>
> Test Summary:
> CheckPatch                    FAIL      4.02 seconds
> GitLint                       PASS      1.89 seconds
> Prep - Setup ELL              PASS      33.60 seconds
> Build - Prep                  PASS      0.77 seconds
> Build - Configure             PASS      10.44 seconds
> Build - Make                  PASS      1169.04 seconds
> Make Check                    PASS      12.60 seconds
> Make Check w/Valgrind         PASS      356.41 seconds
> Make Distcheck                PASS      304.10 seconds
> Build w/ext ELL - Configure   PASS      11.04 seconds
> Build w/ext ELL - Make        PASS      108.76 seconds
> Incremental Build w/ patches  PASS      511.45 seconds
> Scan Build                    WARNING   1239.48 seconds
>
> Details
> ##############################
> Test: CheckPatch - FAIL
> Desc: Run checkpatch.pl script with rule in .checkpatch.conf
> Output:
> [BlueZ,v2,2/4] shared/vcp: Add initial code for handling VCP
> WARNING:PREFER_DEFINED_ATTRIBUTE_MACRO: Prefer __packed over __attribute__((packed))
> #1154: FILE: src/shared/vcp.h:16:
> +#define __packed __attribute__((packed))
>
> /github/workspace/src/12977204.patch total: 0 errors, 1 warnings, 1106 lines checked
>
> NOTE: For some of the reported defects, checkpatch may be able to
>       mechanically convert to the typical style using --fix or --fix-inplace.
>
> /github/workspace/src/12977204.patch has style problems, please review.
>
> NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
>
> NOTE: If any of the errors are false positives, please report
>       them to the maintainer, see CHECKPATCH in MAINTAINERS.
>
> [BlueZ,v2,3/4] profiles: Add initial code for vcp plugin
> ERROR:INITIALISED_STATIC: do not initialise statics to 0
> #395: FILE: profiles/audio/vcp.c:288:
> +static unsigned int vcp_id = 0;
>
> /github/workspace/src/12977206.patch total: 1 errors, 0 warnings, 330 lines checked
>
> NOTE: For some of the reported defects, checkpatch may be able to
>       mechanically convert to the typical style using --fix or --fix-inplace.
>
> /github/workspace/src/12977206.patch has style problems, please review.
>
> NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
>
> NOTE: If any of the errors are false positives, please report
>       them to the maintainer, see CHECKPATCH in MAINTAINERS.
>
>
> ##############################
> Test: Scan Build - WARNING
> Desc: Run Scan Build with patches
> Output:
> *****************************************************************************
> The bugs reported by the scan-build may or may not be caused by your patches.
> Please check the list and fix the bugs if they are caused by your patch.
> *****************************************************************************
> src/shared/vcp.c:285:15: warning: Access to field 'vcs' results in a dereference of a null pointer (loaded from variable 'vdb')
>         if (!vdb && !vdb->vcs)
>                      ^~~~~~~~
> src/shared/vcp.c:294:25: warning: Access to field 'counter' results in a dereference of a null pointer (loaded from variable 'vstate')
>         if (*change_counter != vstate->counter) {
>                                ^~~~~~~~~~~~~~~
> src/shared/vcp.c:318:15: warning: Access to field 'vcs' results in a dereference of a null pointer (loaded from variable 'vdb')
>         if (!vdb && !vdb->vcs)
>                      ^~~~~~~~
> src/shared/vcp.c:327:25: warning: Access to field 'counter' results in a dereference of a null pointer (loaded from variable 'vstate')
>         if (*change_counter != vstate->counter) {
>                                ^~~~~~~~~~~~~~~
> src/shared/vcp.c:351:15: warning: Access to field 'vcs' results in a dereference of a null pointer (loaded from variable 'vdb')
>         if (!vdb && !vdb->vcs)
>                      ^~~~~~~~
> src/shared/vcp.c:360:25: warning: Access to field 'counter' results in a dereference of a null pointer (loaded from variable 'vstate')
>         if (*change_counter != vstate->counter) {
>                                ^~~~~~~~~~~~~~~
> src/shared/vcp.c:385:15: warning: Access to field 'vcs' results in a dereference of a null pointer (loaded from variable 'vdb')
>         if (!vdb && !vdb->vcs)
>                      ^~~~~~~~
> src/shared/vcp.c:394:25: warning: Access to field 'counter' results in a dereference of a null pointer (loaded from variable 'vstate')
>         if (*change_counter != vstate->counter) {
>                                ^~~~~~~~~~~~~~~
> src/shared/vcp.c:419:15: warning: Access to field 'vcs' results in a dereference of a null pointer (loaded from variable 'vdb')
>         if (!vdb && !vdb->vcs)
>                      ^~~~~~~~
> src/shared/vcp.c:428:29: warning: Access to field 'counter' results in a dereference of a null pointer (loaded from variable 'vstate')
>         if (req->change_counter != vstate->counter) {
>                                    ^~~~~~~~~~~~~~~
> src/shared/vcp.c:452:15: warning: Access to field 'vcs' results in a dereference of a null pointer (loaded from variable 'vdb')
>         if (!vdb && !vdb->vcs)
>                      ^~~~~~~~
> src/shared/vcp.c:461:25: warning: Access to field 'counter' results in a dereference of a null pointer (loaded from variable 'vstate')
>         if (*change_counter != vstate->counter) {
>                                ^~~~~~~~~~~~~~~
> src/shared/vcp.c:485:15: warning: Access to field 'vcs' results in a dereference of a null pointer (loaded from variable 'vdb')
>         if (!vdb && !vdb->vcs)
>                      ^~~~~~~~
> src/shared/vcp.c:494:25: warning: Access to field 'counter' results in a dereference of a null pointer (loaded from variable 'vstate')
>         if (*change_counter != vstate->counter) {
>                                ^~~~~~~~~~~~~~~
> 14 warnings generated.

Lets have these warnings fixed so vstate needs to be checked.

>
>
>
> ---
> Regards,
> Linux Bluetooth
>


-- 
Luiz Augusto von Dentz