Received: by 2002:a05:6359:c8b:b0:c7:702f:21d4 with SMTP id go11csp2842989rwb; Mon, 19 Sep 2022 10:46:24 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4QW8USbKVyu5Lw1cG7UdGGJr8nwgDZp6x7/Y+vcMfDvonf6PYPocaUZKUqkbVHPTxiYwAw X-Received: by 2002:a62:4e8e:0:b0:54a:ee65:cde6 with SMTP id c136-20020a624e8e000000b0054aee65cde6mr17663380pfb.42.1663609583792; Mon, 19 Sep 2022 10:46:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663609583; cv=none; d=google.com; s=arc-20160816; b=j7v+dZu7KqGi2R5VV0SOR6pYTIq0CUTZVuaaDeFf8mxtwwct40JyJsSGJLcgkK4Jd+ BgtfvLqtrlCnKSKb4kqDcTCu3iuxhxWnbHI6sKea1B+ISYuCSY4huqkXjnepewXeB2JQ jeJ0z4o8M5KdkG0Y6rQ5Yys9UpkcYUQJARr7GfezoZSnV2j/lr3wV+TeZ4ulVD2d9If7 OCYjt0u+yGILAHzSe+wuYw0SMQu6YeB2aDU5FG9atUVr66nZSC+/m+hJaEmZY2zlj1Lw p5jv1Gac4x+0EQW4qE5zLBfwfiarTsmQntFe7Pn2yx5tFRMr1C356UxYQ6UGcHk1HAbb RGEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=IP9a1LFPsJcc2uIk0bpm58qleC5xdTOi/YkwluNmC3w=; b=qy3QRP/gEDzGnPsFKgzFYpzorCDNXBYH7b0pLNvrikO3ndxQYw8o0lN46HnTWI5Sqr j4F1A/EZm2e8WuMVRibZq/6OtqhVOFV4qWBGW26Ix+jvhLGtsStvDgh7EGZJwgJGPwei QwC5Pv11itWBSiAzcEJxWBgcvORIHr3BlwzYYumd7fsvYxjBH5mYPhhm/3FpvbilmiwK VEwOI8dSbmTwXic2urxvvM3tvLQy3z0GPLU6h3bk1DoOwQJSFdpV3rMxH78e022B9NGA SYcnLXqsyPfa07OliRgx18r5kZRLY2Lx9ljy0Ps1QxFn+fI2HrqMNB2PRfEQws4UmnIm WWqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=DkgjNgZs; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k17-20020a6568d1000000b00434a79d9439si324536pgt.187.2022.09.19.10.46.01; Mon, 19 Sep 2022 10:46:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=DkgjNgZs; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230083AbiISRaY (ORCPT + 99 others); Mon, 19 Sep 2022 13:30:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230261AbiISRaW (ORCPT ); Mon, 19 Sep 2022 13:30:22 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88937BD5 for ; Mon, 19 Sep 2022 10:30:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 25601B81EFD for ; Mon, 19 Sep 2022 17:30:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id D1A64C43140; Mon, 19 Sep 2022 17:30:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663608616; bh=Vg7AgJqVF3WxrTqFQQE/WOfAiLHTy8z8hGHJx+E7TGY=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=DkgjNgZs7TarjcfIc1AhRPAFwWuf5sayP0g6mexL2vAzQ0SqOXkqrqlHpqC67PMAT BL/j5uvPMhyMTUjf4HnLdHQ+2mm8eyZgPA0tL5dfaY7o7RMgBa2wEx14FaU5O1B1n2 QyM/iD0Igiq0YF4lFiErkRQ5tJARaldplzFirtrZYvpQV6tASYKyuU28gSh5Z/+X2K U6fX29o/yz/blSMdCqfq2P7uPa0W/dzs/GsBc55JtHSE0sGnlOk1niIZKcmr+64Gqd +BHbXMTkUmbHcVXxOLSkpcFjOyo3cINDkFiHtaJ5XnmdonmMufZOlV9eD5BQc4msaO dxYVpsrvDeDxg== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id A9722E21ED1; Mon, 19 Sep 2022 17:30:16 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] Bluetooth: L2CAP: initialize delayed works at l2cap_chan_create() From: patchwork-bot+bluetooth@kernel.org Message-Id: <166360861667.29822.12688663792138790626.git-patchwork-notify@kernel.org> Date: Mon, 19 Sep 2022 17:30:16 +0000 References: In-Reply-To: To: Tetsuo Handa Cc: marcel@holtmann.org, johan.hedberg@gmail.com, luiz.dentz@gmail.com, linux-bluetooth@vger.kernel.org, syzkaller-bugs@googlegroups.com, syzbot+83672956c7aa6af698b3@syzkaller.appspotmail.com X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hello: This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz : On Sun, 4 Sep 2022 00:32:56 +0900 you wrote: > syzbot is reporting cancel_delayed_work() without INIT_DELAYED_WORK() at > l2cap_chan_del() [1], for CONF_NOT_COMPLETE flag (which meant to prevent > l2cap_chan_del() from calling cancel_delayed_work()) is cleared by timer > which fires before l2cap_chan_del() is called by closing file descriptor > created by socket(AF_BLUETOOTH, SOCK_STREAM, BTPROTO_L2CAP). > > l2cap_bredr_sig_cmd(L2CAP_CONF_REQ) and l2cap_bredr_sig_cmd(L2CAP_CONF_RSP) > are calling l2cap_ertm_init(chan), and they call l2cap_chan_ready() (which > clears CONF_NOT_COMPLETE flag) only when l2cap_ertm_init(chan) succeeded. > > [...] Here is the summary with links: - Bluetooth: L2CAP: initialize delayed works at l2cap_chan_create() https://git.kernel.org/bluetooth/bluetooth-next/c/2d2cb3066f2c You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html