Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220923145602.25872-1-ceggers@arri.de>
In-Reply-To: <20220923145602.25872-1-ceggers@arri.de>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Fri, 23 Sep 2022 12:18:32 -0700
Message-ID: <CABBYNZLFPY-xiLhiJiJZ1LUQkKpNT7FFbf3sxOhr1Fw7GhBXpA@mail.gmail.com>
Subject: Re: [PATCH BlueZ v2 0/9] properties_changed: check for NULL iterator
To:     Christian Eggers <ceggers@arri.de>
Cc:     linux-bluetooth@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Christian,

On Fri, Sep 23, 2022 at 8:02 AM Christian Eggers <ceggers@arri.de> wrote:

Perhaps you should rephrase to mention the NULL iter is actually the
result of invalidate properties.

> v2:
> ----
> - 7/9: don't call memcpy(x, NULL, 0) [Scan Build]
> - 9/9: shorten GIT summary [GitLint]
>
> Christian Eggers (9):
>   advertising: parse_secondary: fix loop condition
>   advertising: parse_secondary: fix mask value
>   advertising: parse_secondary: check for NULL iterator
>   advertising: parse_min_interval: reset min_interval if iter is NULL
>   advertising: parse_[min|max]_interval: reset value if iter is NULL
>   advertising: parse_tx_power: reset value if iter is NULL
>   client/gatt: proxy_property_changed: check for NULL iterator
>   gatt: proxy_property_changed: check for NULL iterator
>   battery: provided_battery_property_changed_cb: check iterator
>
>  client/gatt.c       | 17 ++++++++++-------
>  src/advertising.c   | 22 +++++++++++++++++-----
>  src/battery.c       | 10 ++++++----
>  src/gatt-database.c | 20 +++++++++++---------
>  4 files changed, 44 insertions(+), 25 deletions(-)
>
> --
> 2.35.3
>


-- 
Luiz Augusto von Dentz