Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <CAP96LmN8mMd5e=ddoUHt2w3HvcUF=8EahqGr6OhOJcjd3QwD0w@mail.gmail.com>
In-Reply-To: <CAP96LmN8mMd5e=ddoUHt2w3HvcUF=8EahqGr6OhOJcjd3QwD0w@mail.gmail.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Mon, 26 Sep 2022 10:50:22 -0700
Message-ID: <CABBYNZ+oGLVEFyNcnJa-i-eO-_PnEzmxGrU3onx-2eoCMa-KoQ@mail.gmail.com>
Subject: Re: [PATCH BlueZ v2] obexd: point DBUS service to obex.service directly
To:     =?UTF-8?B?QW5kcsOpIFc=?= <beppe85@gmail.com>
Cc:     linux-bluetooth@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Andr=C3=A9,

On Sun, Sep 25, 2022 at 12:08 PM Andr=C3=A9 W <beppe85@gmail.com> wrote:
>
> dbus-org.bluez.obex.service user service is not available until
> obex.service is enabled in systemd. By pointing DBUS service directly
> to obex.service, this step can be avoided. The [Alias] section in
> systemd services then becomes unnecessary.

Can we have some more details here, perhaps quote the systemd
documentation if it states why the Alias is not necessary, also does
this affect how the service is activated? Afaik the dbus- suffix was
used to inform that this service starts a D-Bus name.

> ---
>  obexd/src/obex.service.in        | 3 ---
>  obexd/src/org.bluez.obex.service | 2 +-
>  2 files changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/obexd/src/obex.service.in b/obexd/src/obex.service.in
> index fc0dce993..c3f822f55 100644
> --- a/obexd/src/obex.service.in
> +++ b/obexd/src/obex.service.in
> @@ -5,6 +5,3 @@ Description=3DBluetooth OBEX service
>  Type=3Ddbus
>  BusName=3Dorg.bluez.obex
>  ExecStart=3D@pkglibexecdir@/obexd
> -
> -[Install]
> -Alias=3Ddbus-org.bluez.obex.service
> diff --git a/obexd/src/org.bluez.obex.service b/obexd/src/org.bluez.obex.=
service
> index a53808884..c3917e415 100644
> --- a/obexd/src/org.bluez.obex.service
> +++ b/obexd/src/org.bluez.obex.service
> @@ -1,4 +1,4 @@
>  [D-BUS Service]
>  Name=3Dorg.bluez.obex
>  Exec=3D/bin/false
> -SystemdService=3Ddbus-org.bluez.obex.service
> +SystemdService=3Dobex.service
> --
> 2.37.3


--=20
Luiz Augusto von Dentz