Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221006143343.199055-1-abhay.maheshbhai.maheta@intel.com>
In-Reply-To: <20221006143343.199055-1-abhay.maheshbhai.maheta@intel.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Thu, 6 Oct 2022 13:40:48 -0700
Message-ID: <CABBYNZ+5RsGKrMDF8OHX==UxyeAx4vqazkdssxcBqgvUEqBARA@mail.gmail.com>
Subject: Re: [PATCH BlueZ 0/4] Media Control Profile Client
To:     Abhay Maheta <abhay.maheshbhai.maheta@intel.com>
Cc:     linux-bluetooth@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Abhay,

On Thu, Oct 6, 2022 at 7:39 AM Abhay Maheta
<abhay.maheshbhai.maheta@intel.com> wrote:
>
> This series of patches adds support for Media Control Profile for LE Audio.
> These patches primarily foces on Media Control Client Role.
>
> Abhay Maheta (4):
>   lib/uuid: Add GMCS UUIDs
>   shared/mcp: Add initial code for handling MCP
>   profiles: Add initial code for mcp plugin
>   monitor/att: Add decoding support for GMCS
>
>  Makefile.am          |    1 +
>  Makefile.plugins     |    5 +
>  configure.ac         |    4 +
>  lib/uuid.h           |   15 +
>  monitor/att.c        |  511 +++++++++++++++
>  profiles/audio/mcp.c |  429 +++++++++++++
>  src/shared/mcp.c     | 1408 ++++++++++++++++++++++++++++++++++++++++++
>  src/shared/mcp.h     |   60 ++
>  src/shared/mcs.h     |   65 ++
>  9 files changed, 2498 insertions(+)
>  create mode 100644 profiles/audio/mcp.c
>  create mode 100644 src/shared/mcp.c
>  create mode 100644 src/shared/mcp.h
>  create mode 100644 src/shared/mcs.h
>
> --
> 2.25.1

Please fix the code style, there are quite a few problems with that,
it would also be great to give some information on how the plugin
works for instance does it work with bluetoothctl player menu?

-- 
Luiz Augusto von Dentz