Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <28551f84-eff3-74fa-b17c-cfa16b027280@gmail.com>
Date:   Wed, 19 Oct 2022 00:02:40 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.2.2
Subject: Re: [PATCH] Bluetooth: hci_conn: Fix not restoring ISO buffer count
 on disconnect
Content-Language: fr
To:     Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
        linux-bluetooth@vger.kernel.org
References: <20221017224147.3629459-1-luiz.dentz@gmail.com>
From:   =?UTF-8?Q?Fr=c3=a9d=c3=a9ric_Danis?= <frederic.danis.oss@gmail.com>
In-Reply-To: <20221017224147.3629459-1-luiz.dentz@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Luiz,

I tested this patch and I'm not able to reproduce the issue after 
applying it.

Tested-by: Frédéric Danis <frederic.danis@collabora.com>


Le 18/10/2022 à 00:41, Luiz Augusto von Dentz a écrit :
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> When disconnecting an ISO link the controller may not generate
> HCI_EV_NUM_COMP_PKTS for unacked packets which needs to be restored in
> hci_conn_del otherwise the host would assume they are still in use and
> would not be able to use all the buffers available.
> 
> Fixes: 26afbd826ee3 ("Bluetooth: Add initial implementation of CIS connections")
> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> ---
>   net/bluetooth/hci_conn.c | 11 +++++++++++
>   1 file changed, 11 insertions(+)
> 
> diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c
> index 5d6ee5075642..df914f521c9d 100644
> --- a/net/bluetooth/hci_conn.c
> +++ b/net/bluetooth/hci_conn.c
> @@ -1067,10 +1067,21 @@ int hci_conn_del(struct hci_conn *conn)
>   			hdev->acl_cnt += conn->sent;
>   	} else {
>   		struct hci_conn *acl = conn->link;
> +
>   		if (acl) {
>   			acl->link = NULL;
>   			hci_conn_drop(acl);
>   		}
> +
> +		/* Unacked ISO frames */
> +		if (conn->type == ISO_LINK) {
> +			if (hdev->iso_pkts)
> +				hdev->iso_cnt += conn->sent;
> +			else if (hdev->le_pkts)
> +				hdev->le_cnt += conn->sent;
> +			else
> +				hdev->acl_cnt += conn->sent;
> +		}
>   	}
>   
>   	if (conn->amp_mgr)

-- 
Frédéric Danis                       Embedded Linux Consultant
frederic.danis.oss@gmail.com