Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp3441574rwi; Fri, 21 Oct 2022 16:50:48 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6jbcGt31T4e0fIP/xTjgAObUBb/k96kx3nJ4R7AMkYo6o5WIYcS8oDT630ebzcfJn22Tey X-Received: by 2002:a05:6402:428f:b0:454:c988:4bb1 with SMTP id g15-20020a056402428f00b00454c9884bb1mr19470578edc.196.1666396248049; Fri, 21 Oct 2022 16:50:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666396248; cv=none; d=google.com; s=arc-20160816; b=n/ud59aC5EtJRnV6AZ+jp3t5AvmtWJF6PufQipN8ZdqBuc/DHV5M2bCZA4BC/C6a+j i6j27vsGbXA/oEsCvZrryfJ4ofrK1bcvScGTlZ7Ig68Z24A6ezlNGuEj6ykPklYi/gBV x0wLvAM3u9UEtcdgDRm1jzaEGntJxldYfF4y4MOnbfy5nOGcWNxGtPuY5gNt2vBFY5y1 KSmXIWqqmCCjuouPXAiX6yAC7lko3rtHYbYc6ZoRinRka/Q9eHgzSr3oYsF1nazyHkSz yq+1MFhj/pFJWeBVyXQhQF3htpuqaLDFyHfocXDW2rHqURazTiEtVFHwAvSMl0Fx1676 dH2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=vxgmw5vXy0iq4mAkVZuBsKRQMzeO/skRTBi6LUmRhUw=; b=nU/jzYxebuhSIb3bJ7C4JWcbDLtA2v4jHFSohuKVZj5dJpN7dpP52aP+QpKSRQkAow Pga1FPtohmcMxKtlTVsO/zEFd9tWz4mTGwpDdcqeuU+UKzHiNjwL4DGwPYskysKcc9U7 KBVzjekhuMnNFuhOLN91vcorEBWShCLXa094txGbsap+X2H0aEV5Rf+1VSM+ISpmI78y gnkUqFUp0slTnOv2l8Q3hSCzVM6+1ASESMywS7tDR+1BJz0opEPO7gK6AZGhytxjBHr3 tLC1u4OrvNbQsS2LJU8twg/oosZiVdD0hZrdxxVHpfCSHVtMhvXtzF647Uyvq5ckrz0D +x0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=hvQRm0Ua; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gn28-20020a1709070d1c00b0078d9f1f72bcsi23393322ejc.726.2022.10.21.16.49.44; Fri, 21 Oct 2022 16:50:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=hvQRm0Ua; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229744AbiJUXq2 (ORCPT + 99 others); Fri, 21 Oct 2022 19:46:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229514AbiJUXq1 (ORCPT ); Fri, 21 Oct 2022 19:46:27 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B553929E982 for ; Fri, 21 Oct 2022 16:46:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666395985; x=1697931985; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=EFytebbYZoCeX9gjAXjbpSSAPQnhCm/i6i0o5IymFKw=; b=hvQRm0UapHIWcI6Cnf77jgQuEaqlpYZepAEqX21RxsuEMtdkrHO8BgNQ Marl8Dl+Hy4B56sSDMPj8vL/zsbk8SHAANVJtgM1VI5xzVhfjCcZjs7Wd hEcrJNBCzxO3+/MuYU656g8cboWIf+3SmpG8bwzrH6nnbbwp1OLixJTof zEVPCOqbh/t8xwFfqIuRzNnZ+v1q+21BnzA9r2eEj0l9eYYurngx1V/ws GeJqoVYI607Bnqc7HUYuKJxcidhCROzkO7/+X+pdxtyIhvByuKofoRYci Xy5BOjxyQJuA/fxzlGj8cdJz0fuJVmhveabdwII097Yv+kEwnlEUzNYEV Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10507"; a="287529943" X-IronPort-AV: E=Sophos;i="5.95,203,1661842800"; d="scan'208";a="287529943" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Oct 2022 16:46:25 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10507"; a="633126976" X-IronPort-AV: E=Sophos;i="5.95,203,1661842800"; d="scan'208";a="633126976" Received: from bmitch7x-mobl.amr.corp.intel.com (HELO istotlan-mobl1.intel.com) ([10.209.0.254]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Oct 2022 16:46:25 -0700 From: Inga Stotland To: linux-bluetooth@vger.kernel.org Cc: luiz.von.dentz@intel.com, Inga Stotland Subject: [PATCH] Bluetooth: MGMT: Fix error report for ADD_EXT_ADV_PARAMS Date: Fri, 21 Oct 2022 16:46:17 -0700 Message-Id: <20221021234617.28848-1-inga.stotland@intel.com> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org When validating the parameter length for MGMT_OP_ADD_EXT_ADV_PARAMS command, use the correct op code in error status report: was MGMT_OP_ADD_ADVERTISING, changed to MGMT_OP_ADD_EXT_ADV_PARAMS. Signed-off-by: Inga Stotland --- net/bluetooth/mgmt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c index a92e7e485feb..0dd30a3beb77 100644 --- a/net/bluetooth/mgmt.c +++ b/net/bluetooth/mgmt.c @@ -8859,7 +8859,7 @@ static int add_ext_adv_params(struct sock *sk, struct hci_dev *hdev, * extra parameters we don't know about will be ignored in this request. */ if (data_len < MGMT_ADD_EXT_ADV_PARAMS_MIN_SIZE) - return mgmt_cmd_status(sk, hdev->id, MGMT_OP_ADD_ADVERTISING, + return mgmt_cmd_status(sk, hdev->id, MGMT_OP_ADD_EXT_ADV_PARAMS, MGMT_STATUS_INVALID_PARAMS); flags = __le32_to_cpu(cp->flags); -- 2.37.3