Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221021234617.28848-1-inga.stotland@intel.com>
In-Reply-To: <20221021234617.28848-1-inga.stotland@intel.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Fri, 21 Oct 2022 16:58:39 -0700
Message-ID: <CABBYNZLDtNcr6YUuUXqRzeY2GG=gcf5p5RsELagNDHcShBo23Q@mail.gmail.com>
Subject: Re: [PATCH] Bluetooth: MGMT: Fix error report for ADD_EXT_ADV_PARAMS
To:     Inga Stotland <inga.stotland@intel.com>
Cc:     linux-bluetooth@vger.kernel.org, luiz.von.dentz@intel.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Inga,

On Fri, Oct 21, 2022 at 4:50 PM Inga Stotland <inga.stotland@intel.com> wrote:
>
> When validating the parameter length for MGMT_OP_ADD_EXT_ADV_PARAMS
> command, use the correct op code in error status report:
> was MGMT_OP_ADD_ADVERTISING, changed to MGMT_OP_ADD_EXT_ADV_PARAMS.

Please add the Fixes tag:

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-changes

> Signed-off-by: Inga Stotland <inga.stotland@intel.com>
> ---
>  net/bluetooth/mgmt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
> index a92e7e485feb..0dd30a3beb77 100644
> --- a/net/bluetooth/mgmt.c
> +++ b/net/bluetooth/mgmt.c
> @@ -8859,7 +8859,7 @@ static int add_ext_adv_params(struct sock *sk, struct hci_dev *hdev,
>          * extra parameters we don't know about will be ignored in this request.
>          */
>         if (data_len < MGMT_ADD_EXT_ADV_PARAMS_MIN_SIZE)
> -               return mgmt_cmd_status(sk, hdev->id, MGMT_OP_ADD_ADVERTISING,
> +               return mgmt_cmd_status(sk, hdev->id, MGMT_OP_ADD_EXT_ADV_PARAMS,
>                                        MGMT_STATUS_INVALID_PARAMS);
>
>         flags = __le32_to_cpu(cp->flags);
> --
> 2.37.3
>


-- 
Luiz Augusto von Dentz