Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <abb598cd-c849-33b8-34fa-4cedcf185138@molgen.mpg.de>
Date:   Thu, 27 Oct 2022 13:18:43 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH v1] Bluetooth: btusb: Fix enable failure for a CSR BT
 dongle
Content-Language: en-US
To:     Zijun Hu <quic_zijuhu@quicinc.com>
Cc:     marcel@holtmann.org, johan.hedberg@gmail.com, luiz.dentz@gmail.com,
        luiz.von.dentz@intel.com, linux-kernel@vger.kernel.org,
        linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org,
        Zijun Hu <zijuhu@qti.qualcomm.com>
References: <1666868760-4680-1-git-send-email-quic_zijuhu@quicinc.com>
From:   Paul Menzel <pmenzel@molgen.mpg.de>
In-Reply-To: <1666868760-4680-1-git-send-email-quic_zijuhu@quicinc.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Dear Zijun,


Thank you for the patch.


Am 27.10.22 um 13:06 schrieb Zijun Hu:
> From: Zijun Hu <zijuhu@qti.qualcomm.com>

I‘d be more specific in the summary/title. Maybe:

Correct quirk check to include BT 4.0

> A CSR BT dongle fails to be enabled bcz it is not detected as fake

I’d write *because*.

> rightly, fixed by correcting fake detection condition.
> 
> below btmon error log says HCI_QUIRK_BROKEN_FILTER_CLEAR_ALL is not set.
> 
> < HCI Command: Set Event Filter (0x03|0x0005) plen 1        #23 [hci0]
>          Type: Clear All Filters (0x00)
>> HCI Event: Command Complete (0x0e) plen 4                 #24 [hci0]
>        Set Event Filter (0x03|0x0005) ncmd 1
>          Status: Invalid HCI Command Parameters (0x12)
> 
> the quirk is not set bcz current fake detection does not mark the dongle
> as fake with below version info.
> 
> < HCI Command: Read Local Version In.. (0x04|0x0001) plen 0  #1 [hci0]
>> HCI Event: Command Complete (0x0e) plen 12                 #2 [hci0]
>        Read Local Version Information (0x04|0x0001) ncmd 1
>          Status: Success (0x00)
>          HCI version: Bluetooth 4.0 (0x06) - Revision 12576 (0x3120)
>          LMP version: Bluetooth 4.0 (0x06) - Subversion 8891 (0x22bb)
>          Manufacturer: Cambridge Silicon Radio (10)
> 
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=60824
> Signed-off-by: Zijun Hu <zijuhu@qti.qualcomm.com>

Please add a Fixes: tag.


Kind regards,

Paul


> ---
>   drivers/bluetooth/btusb.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index 420be2ee2acf..727469d073f9 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -2155,7 +2155,7 @@ static int btusb_setup_csr(struct hci_dev *hdev)
>   		is_fake = true;
>   
>   	else if (le16_to_cpu(rp->lmp_subver) <= 0x22bb &&
> -		 le16_to_cpu(rp->hci_ver) > BLUETOOTH_VER_4_0)
> +		 le16_to_cpu(rp->hci_ver) >= BLUETOOTH_VER_4_0)
>   		is_fake = true;
>   
>   	/* Other clones which beat all the above checks */