Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221027150822.26120-2-sven@svenpeter.dev> <635aae47.c80a0220.f8596.406a@mx.google.com>
In-Reply-To: <635aae47.c80a0220.f8596.406a@mx.google.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Fri, 28 Oct 2022 12:04:13 -0700
Message-ID: <CABBYNZJHUEtT7QPx7rFkS0=CiEqWpDz7=q98p9qPcR-XBdWCEw@mail.gmail.com>
Subject: Re: Broadcom/Apple Bluetooth driver for Apple Silicon
To:     linux-bluetooth@vger.kernel.org
Cc:     sven@svenpeter.dev, Tedd Ho-Jeong An <hj.tedd.an@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Tedd,

On Thu, Oct 27, 2022 at 9:20 AM <bluez.test.bot@gmail.com> wrote:
>
> This is automated email and please do not reply to this email!
>
> Dear submitter,
>
> Thank you for submitting the patches to the linux bluetooth mailing list.
> This is a CI test results with your patch series:
> PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=689494
>
> ---Test result---
>
> Test Summary:
> CheckPatch                    FAIL      6.26 seconds
> GitLint                       FAIL      1.97 seconds
> SubjectPrefix                 FAIL      2.59 seconds
> BuildKernel                   PASS      33.98 seconds
> BuildKernel32                 PASS      30.00 seconds
> Incremental Build with patchesPASS      146.18 seconds
> TestRunner: Setup             PASS      506.50 seconds
> TestRunner: l2cap-tester      PASS      17.12 seconds
> TestRunner: iso-tester        PASS      16.02 seconds
> TestRunner: bnep-tester       PASS      6.33 seconds
> TestRunner: mgmt-tester       PASS      103.02 seconds
> TestRunner: rfcomm-tester     PASS      10.09 seconds
> TestRunner: sco-tester        PASS      9.42 seconds
> TestRunner: ioctl-tester      PASS      10.55 seconds
> TestRunner: mesh-tester       PASS      7.71 seconds
> TestRunner: smp-tester        PASS      9.46 seconds
> TestRunner: userchan-tester   PASS      6.54 seconds
>
> Details
> ##############################
> Test: CheckPatch - FAIL - 6.26 seconds
> Run checkpatch.pl script with rule in .checkpatch.conf
> [v4,1/7] dt-bindings: net: Add generic Bluetooth controller\Traceback (most recent call last):
>   File "scripts/spdxcheck.py", line 6, in <module>
>     from ply import lex, yacc

We might want to fix this to install the ply module.

> ModuleNotFoundError: No module named 'ply'
> WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
> #115:
>  .../{ => bluetooth}/qualcomm-bluetooth.yaml   |  6 ++--
>
> WARNING:DT_SPLIT_BINDING_PATCH: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst
>
> WARNING:DT_SPLIT_BINDING_PATCH: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst
>
> total: 0 errors, 3 warnings, 71 lines checked
>
> NOTE: For some of the reported defects, checkpatch may be able to
>       mechanically convert to the typical style using --fix or --fix-inplace.
>
> /github/workspace/src/13022301.patch has style problems, please review.
>
> NOTE: Ignored message types: UNKNOWN_COMMIT_ID
>
> NOTE: If any of the errors are false positives, please report
>       them to the maintainer, see CHECKPATCH in MAINTAINERS.
>
> [v4,3/7] arm64: dts: apple: t8103: Add Bluetooth controller\WARNING:UNDOCUMENTED_DT_STRING: DT compatible string vendor "pci14e4" appears un-documented -- check ./Documentation/devicetree/bindings/vendor-prefixes.yaml
> #210: FILE: arch/arm64/boot/dts/apple/t8103-jxxx.dtsi:83:
> +               compatible = "pci14e4,5f69";
>
> total: 0 errors, 1 warnings, 68 lines checked
>
> NOTE: For some of the reported defects, checkpatch may be able to
>       mechanically convert to the typical style using --fix or --fix-inplace.
>
> /github/workspace/src/13022303.patch has style problems, please review.
>
> NOTE: Ignored message types: UNKNOWN_COMMIT_ID
>
> NOTE: If any of the errors are false positives, please report
>       them to the maintainer, see CHECKPATCH in MAINTAINERS.
>
>
> ##############################
> Test: GitLint - FAIL - 1.97 seconds
> Run gitlint with rule in .gitlint
> [v4,1/7] dt-bindings: net: Add generic Bluetooth controller
> 15: B1 Line exceeds max length (93>80): " create mode 100644 Documentation/devicetree/bindings/net/bluetooth/bluetooth-controller.yaml"
> 16: B1 Line exceeds max length (91>80): " rename Documentation/devicetree/bindings/net/{ => bluetooth}/qualcomm-bluetooth.yaml (96%)"
>
> [v4,2/7] dt-bindings: net: Add Broadcom BCM4377 family PCIe Bluetooth
> 14: B1 Line exceeds max length (95>80): " create mode 100644 Documentation/devicetree/bindings/net/bluetooth/brcm,bcm4377-bluetooth.yaml"
>
>
> ##############################
> Test: SubjectPrefix - FAIL - 2.59 seconds
> Check subject contains "Bluetooth" prefix
> "Bluetooth: " is not specified in the subject
> "Bluetooth: " is not specified in the subject
> "Bluetooth: " is not specified in the subject

@Sven you can probably ignore these errors since not all patches are
bluetooth specific these are probably a false positives.

@Tedd Btw, for new drivers the CI won't be able to build test so I
wonder if we should have a special Kconfig option that select all the
drivers so we don't have to keep updating the ci.config everytime a
new driver is introduced?

-- 
Luiz Augusto von Dentz