Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221029170408.175533-1-abhay.maheshbhai.maheta@intel.com> <20221029170408.175533-5-abhay.maheshbhai.maheta@intel.com>
In-Reply-To: <20221029170408.175533-5-abhay.maheshbhai.maheta@intel.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Mon, 31 Oct 2022 13:57:35 -0700
Message-ID: <CABBYNZ+vgDyaAw9oLZpSMs8NXyrttLD7g7AzBYs8pedDRkQRDQ@mail.gmail.com>
Subject: Re: [PATCH BlueZ 4/5] media-api: Add CompanyID, VendorCodecID, Metadata
To:     Abhay Maheta <abhay.maheshbhai.maheta@intel.com>
Cc:     linux-bluetooth@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Abhay,

On Sat, Oct 29, 2022 at 9:54 AM Abhay Maheta
<abhay.maheshbhai.maheta@intel.com> wrote:
>
> From: "Maheta, Abhay" <abhay.maheshbhai.maheta@intel.com>
>
> This adds CompanyID, VendorCodecID, Metadata for RegisterEndpoint method
> ---
>  doc/media-api.txt | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>
> diff --git a/doc/media-api.txt b/doc/media-api.txt
> index 847f8bee7..ce2b74e53 100644
> --- a/doc/media-api.txt
> +++ b/doc/media-api.txt
> @@ -34,11 +34,29 @@ Methods             void RegisterEndpoint(object endpoint, dict properties)
>                                         match the profile specification which
>                                         is indicated by the UUID.
>
> +                               uint16_t CompanyID:
> +
> +                                       Assigned number of Company ID that the
> +                                       endpoint implements. It should be set to
> +                                       appropriate value when Vendor Specific
> +                                       Codec is used.
> +
> +                               uint16_t VendorCodecID:
> +
> +                                       Vendor-specific codec ID that the endpoint
> +                                       implements. It should be set to appropriate
> +                                       value when Vendor Specific Codec is used.

I think we can be a less confusing with respect to CodecID, so instead
of using the special 0xff to determine the endpoint is registering a
vendor codec we can use the CompanyID directly, so if it is present
(D-Bus property exists) then codec ID is used a vid and the codec id
is set to 0x0ff.

We also need to document if CompanyID is BAP only or not, afaik for
A2DP we do have this information prepended into the Capabilities, but
I think adding the CompanyID is better so I wouldn't oppose adding
support for it also in A2DP.

>                                 array{byte} Capabilities:
>
>                                         Capabilities blob, it is used as it is
>                                         so the size and byte order must match.
>
> +                               array{byte} Metadata:
> +
> +                                       Metadata blob, it is used as it is
> +                                       so the size and byte order must match.
> +
>                         Possible Errors: org.bluez.Error.InvalidArguments
>                                          org.bluez.Error.NotSupported - emitted
>                                          when interface for the end-point is
> --
> 2.25.1
>


-- 
Luiz Augusto von Dentz